| Message ID | 20260909-drop-camera-sensor-raw-v1-1-e0760bc2b610@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
On Wed, Sep 09, 2026 at 12:40:51PM +0530, Jai Luthra wrote: > Currently, the priority for CameraSensorRaw is higher than > CameraSensorLegacy, so sensor drivers that are migrated to the new > V4L2 raw sensor model "match" it as they use internal streams for > metadata. However, they error out during registration because of the > newly introduced generic formats and other minor differences. > > We should avoid regressions for users who update their kernel in > the future (when raw sensor model support is mainlined) without > simultaneously updating libcamera. > > To prevent this, temporarily drop the priority of CameraSensorRaw class > to -200, placing it below CameraSensorLegacy. This can be restored once > the new model is finalized, available in mainline, and CameraSensorRaw > is updated to match. > > Fixes: a09c7f212 ("libcamera: Add CameraSensor implementation for raw V4L2 sensors") > Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/sensor/camera_sensor_raw.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/sensor/camera_sensor_raw.cpp b/src/libcamera/sensor/camera_sensor_raw.cpp > index e50111f1d..6344a34fc 100644 > --- a/src/libcamera/sensor/camera_sensor_raw.cpp > +++ b/src/libcamera/sensor/camera_sensor_raw.cpp > @@ -1170,6 +1170,6 @@ std::string CameraSensorRaw::logPrefix() const > return "'" + entity_->name() + "'"; > } > > -REGISTER_CAMERA_SENSOR(CameraSensorRaw, 0) > +REGISTER_CAMERA_SENSOR(CameraSensorRaw, -200) > > } /* namespace libcamera */ > > --- > base-commit: aebe4861c087ce9a0cb417151d5316a1fdb2e792 > change-id: 20260909-drop-camera-sensor-raw-22cc6f0521b2
diff --git a/src/libcamera/sensor/camera_sensor_raw.cpp b/src/libcamera/sensor/camera_sensor_raw.cpp index e50111f1d..6344a34fc 100644 --- a/src/libcamera/sensor/camera_sensor_raw.cpp +++ b/src/libcamera/sensor/camera_sensor_raw.cpp @@ -1170,6 +1170,6 @@ std::string CameraSensorRaw::logPrefix() const return "'" + entity_->name() + "'"; } -REGISTER_CAMERA_SENSOR(CameraSensorRaw, 0) +REGISTER_CAMERA_SENSOR(CameraSensorRaw, -200) } /* namespace libcamera */
Currently, the priority for CameraSensorRaw is higher than CameraSensorLegacy, so sensor drivers that are migrated to the new V4L2 raw sensor model "match" it as they use internal streams for metadata. However, they error out during registration because of the newly introduced generic formats and other minor differences. We should avoid regressions for users who update their kernel in the future (when raw sensor model support is mainlined) without simultaneously updating libcamera. To prevent this, temporarily drop the priority of CameraSensorRaw class to -200, placing it below CameraSensorLegacy. This can be restored once the new model is finalized, available in mainline, and CameraSensorRaw is updated to match. Fixes: a09c7f212 ("libcamera: Add CameraSensor implementation for raw V4L2 sensors") Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com> --- src/libcamera/sensor/camera_sensor_raw.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: aebe4861c087ce9a0cb417151d5316a1fdb2e792 change-id: 20260909-drop-camera-sensor-raw-22cc6f0521b2 Best regards,