| Message ID | 20260908161805.335568-1-dmanresa@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hello - thanks for the patch, but this has been superseded by the IPU3 libipa rework which fixes the same issue (albeit slightly differently) Thanks Dan On 08/09/2026 17:18, D. Manresa wrote: > The AWB gains passed to the AGC traits are built as { red, blue, green }, > but the RGB vector expects { red, green, blue }. The luminance estimate > therefore weights the blue statistics with the green gain and the green > statistics with the blue gain, which biases the exposure whenever the two > gains differ (on an OV5670 they are 1.0 and ~1.8). > > Pass the gains in RGB order. > > Signed-off-by: D. Manresa <dmanresa@gmail.com> > Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> > --- > Changes in v2: > - Rebase on current master (the bug is still present after the > AgcAlgorithm port). > - Add Dan's Reviewed-by. > > src/ipa/ipu3/algorithms/agc.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp > index 57cfb32..dd4f1ab 100644 > --- a/src/ipa/ipu3/algorithms/agc.cpp > +++ b/src/ipa/ipu3/algorithms/agc.cpp > @@ -224,8 +224,8 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame, > rgbTriples_, > {{ > context.activeState.awb.gains.red, > - context.activeState.awb.gains.blue, > context.activeState.awb.gains.green, > + context.activeState.awb.gains.blue, > }}, > bdsGrid_, > },
diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp index 57cfb32..dd4f1ab 100644 --- a/src/ipa/ipu3/algorithms/agc.cpp +++ b/src/ipa/ipu3/algorithms/agc.cpp @@ -224,8 +224,8 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame, rgbTriples_, {{ context.activeState.awb.gains.red, - context.activeState.awb.gains.blue, context.activeState.awb.gains.green, + context.activeState.awb.gains.blue, }}, bdsGrid_, },
The AWB gains passed to the AGC traits are built as { red, blue, green }, but the RGB vector expects { red, green, blue }. The luminance estimate therefore weights the blue statistics with the green gain and the green statistics with the blue gain, which biases the exposure whenever the two gains differ (on an OV5670 they are 1.0 and ~1.8). Pass the gains in RGB order. Signed-off-by: D. Manresa <dmanresa@gmail.com> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> --- Changes in v2: - Rebase on current master (the bug is still present after the AgcAlgorithm port). - Add Dan's Reviewed-by. src/ipa/ipu3/algorithms/agc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)