[libcamera-devel,1/6] Documentation: coding_style: Add move semantics to C++11 features

Message ID 20190121005930.10112-2-laurent.pinchart@ideasonboard.com
State Superseded
Headers show
Series
  • Extend the logger with categories and configuration
Related show

Commit Message

Laurent Pinchart Jan. 21, 2019, 12:59 a.m. UTC
Add the move semantics (move constructor and move assignment) to the
allowed C++11 features, as we extensively use them for the unique and
shared pointers.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 Documentation/coding-style.rst | 1 +
 1 file changed, 1 insertion(+)

Comments

Niklas Söderlund Jan. 21, 2019, 10:23 a.m. UTC | #1
Hi Laurent,

Thanks for your work.

On 2019-01-21 02:59:25 +0200, Laurent Pinchart wrote:
> Add the move semantics (move constructor and move assignment) to the
> allowed C++11 features, as we extensively use them for the unique and
> shared pointers.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  Documentation/coding-style.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst
> index 66db3cebe132..30a1455d8c65 100644
> --- a/Documentation/coding-style.rst
> +++ b/Documentation/coding-style.rst
> @@ -80,6 +80,7 @@ C++-11-specific features:
>    Smart pointers, as well as shared pointers and weak pointers, shall not be
>    overused.
>  * Variadic class and function templates
> +* rvalue references, move constructor and move assignment
>  
>  Object Ownership
>  ~~~~~~~~~~~~~~~~
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst
index 66db3cebe132..30a1455d8c65 100644
--- a/Documentation/coding-style.rst
+++ b/Documentation/coding-style.rst
@@ -80,6 +80,7 @@  C++-11-specific features:
   Smart pointers, as well as shared pointers and weak pointers, shall not be
   overused.
 * Variadic class and function templates
+* rvalue references, move constructor and move assignment
 
 Object Ownership
 ~~~~~~~~~~~~~~~~