[libcamera-devel,v3] libcamera: pipeline_handler: Fix the compilation issue in musl

Message ID 1580463140-31163-1-git-send-email-madhavan.krishnan@linaro.org
State Accepted
Commit b448bfb426067a05d92a51f3ff123898a91ea643
Headers show
Series
  • [libcamera-devel,v3] libcamera: pipeline_handler: Fix the compilation issue in musl
Related show

Commit Message

Madhavan Krishnan Jan. 31, 2020, 9:32 a.m. UTC
sys/sysmacros.h was an incorrect choice, which doesn't work with musl.

Fixes: effe4d6

Signed-off-by: Madhavan Krishnan <madhavan.krishnan@linaro.org>
---
 src/libcamera/include/pipeline_handler.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham Feb. 5, 2020, 8:38 a.m. UTC | #1
Hi Madhavan,

Thanks for your investigation and patch.

I've pushed this with a slightly updated commit message to master.
--
Kieran


On 31/01/2020 09:32, Madhavan Krishnan wrote:
> sys/sysmacros.h was an incorrect choice, which doesn't work with musl.
> 
> Fixes: effe4d6
> 
> Signed-off-by: Madhavan Krishnan <madhavan.krishnan@linaro.org>
> ---
>  src/libcamera/include/pipeline_handler.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
> index a6c1e1f..97157dd 100644
> --- a/src/libcamera/include/pipeline_handler.h
> +++ b/src/libcamera/include/pipeline_handler.h
> @@ -12,7 +12,7 @@
>  #include <memory>
>  #include <set>
>  #include <string>
> -#include <sys/sysmacros.h>
> +#include <sys/types.h>
>  #include <vector>
>  
>  #include <ipa/ipa_interface.h>
>

Patch

diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
index a6c1e1f..97157dd 100644
--- a/src/libcamera/include/pipeline_handler.h
+++ b/src/libcamera/include/pipeline_handler.h
@@ -12,7 +12,7 @@ 
 #include <memory>
 #include <set>
 #include <string>
-#include <sys/sysmacros.h>
+#include <sys/types.h>
 #include <vector>
 
 #include <ipa/ipa_interface.h>