| Message ID | 20260714030843.1191059-1-paul.elder@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
On Tue, Jul 14, 2026 at 12:08:43PM +0900, Paul Elder wrote: > Add sensor properties for the IMX335 for the test pattern mode. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > --- > src/libcamera/sensor/camera_sensor_properties.cpp | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp > index b18524d85b37..91e2ce628794 100644 > --- a/src/libcamera/sensor/camera_sensor_properties.cpp > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp > @@ -117,7 +117,11 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > } }, > { "imx335", { > .unitCellSize = { 2000, 2000 }, > - .testPatternModes = {}, > + .testPatternModes = { > + { controls::draft::TestPatternModeOff, 0 }, > + { controls::draft::TestPatternModeSolidColor, 4 }, > + { controls::draft::TestPatternModeColorBars, 12} Missing space before } and trailing comma. > + }, > } }, > { "imx415", { > .unitCellSize = { 1450, 1450 },
Hi Paul On Tue, Jul 14, 2026 at 12:08:43PM +0900, Paul Elder wrote: > Add sensor properties for the IMX335 for the test pattern mode. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > --- > src/libcamera/sensor/camera_sensor_properties.cpp | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp > index b18524d85b37..91e2ce628794 100644 > --- a/src/libcamera/sensor/camera_sensor_properties.cpp > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp > @@ -117,7 +117,11 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > } }, > { "imx335", { > .unitCellSize = { 2000, 2000 }, > - .testPatternModes = {}, > + .testPatternModes = { > + { controls::draft::TestPatternModeOff, 0 }, > + { controls::draft::TestPatternModeSolidColor, 4 }, > + { controls::draft::TestPatternModeColorBars, 12} > + }, This is the list registered by the mainline driver "Disabled", "All 000h", "All FFFh", "All 555h", "All AAAh", <--- SolidColor "Toggle 555/AAAh", "Toggle AAA/555h", "Toggle 000/555h", "Toggle 555/000h", "Toggle 000/FFFh", "Toggle FFF/000h", "Horizontal color bars", "Vertical color bars", <--- ColorBars Why has 0xaaa being preferred over fff and 555 ? I don't think it makes a big difference though I can merge this and address Laurent's comment if you confirm selecting 0xaaa gives the best results Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks j > } }, > { "imx415", { > .unitCellSize = { 1450, 1450 }, > -- > 2.47.2 >
diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp index b18524d85b37..91e2ce628794 100644 --- a/src/libcamera/sensor/camera_sensor_properties.cpp +++ b/src/libcamera/sensor/camera_sensor_properties.cpp @@ -117,7 +117,11 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen } }, { "imx335", { .unitCellSize = { 2000, 2000 }, - .testPatternModes = {}, + .testPatternModes = { + { controls::draft::TestPatternModeOff, 0 }, + { controls::draft::TestPatternModeSolidColor, 4 }, + { controls::draft::TestPatternModeColorBars, 12} + }, } }, { "imx415", { .unitCellSize = { 1450, 1450 },
Add sensor properties for the IMX335 for the test pattern mode. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- src/libcamera/sensor/camera_sensor_properties.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)