[08/30] libcamera: software_isp: gpu: Drop unused method definitions
diff mbox series

Message ID 20260618122245.946138-9-bryan.odonoghue@linaro.org
State RFC
Headers show
Series
  • RFC/RFT: gpuisp: Multipass with speed optimisations on top
Related show

Commit Message

Bryan O'Donoghue June 18, 2026, 12:22 p.m. UTC 
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 src/libcamera/software_isp/software_isp_pipeline_gpu.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Milan Zamazal June 23, 2026, 10:18 a.m. UTC | #1 
s/definitions/definition/

Not used already in master -- could it be moved to the front to merge
quickly in the next iteration?  Either way:

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>

Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:

> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  src/libcamera/software_isp/software_isp_pipeline_gpu.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.h b/src/libcamera/software_isp/software_isp_pipeline_gpu.h
> index 6a9df2f04..6bd8adc8f 100644
> --- a/src/libcamera/software_isp/software_isp_pipeline_gpu.h
> +++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.h
> @@ -62,7 +62,6 @@ private:
>  	int getShaderVariableLocations();
>  	void setShaderVariableValues(const DebayerParams &params);
>  	int processGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams &params, std::optional<MappedFrameBuffer> *mappedInputBuffer, std::optional<DmaSyncer> *inputBufferDmaSyncer);
> -	void configureTexture(GLuint &texture);
>  
>  	/* Pointer to object representing input texture */
>  	std::unique_ptr<eGLImage> eglImageBayerIn_;

Patch
diff mbox series 

diff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.h b/src/libcamera/software_isp/software_isp_pipeline_gpu.h
index 6a9df2f04..6bd8adc8f 100644
--- a/src/libcamera/software_isp/software_isp_pipeline_gpu.h
+++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.h
@@ -62,7 +62,6 @@  private:
 	int getShaderVariableLocations();
 	void setShaderVariableValues(const DebayerParams &params);
 	int processGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams &params, std::optional<MappedFrameBuffer> *mappedInputBuffer, std::optional<DmaSyncer> *inputBufferDmaSyncer);
-	void configureTexture(GLuint &texture);
 
 	/* Pointer to object representing input texture */
 	std::unique_ptr<eGLImage> eglImageBayerIn_;