| Message ID | 20260615-libipa-algorithms-v1-10-e949c937422e@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Quoting Jacopo Mondi (2026-06-15 15:05:35) > Store the sensorInfo in the IPAContext. It will be used by the Lsc > algorithm to support polynomial LSC tables. > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Bits like this which will always be common still make me think there should be some IPA::CameraSensor or commonality for what the CamHelper's have as a way of interacting with the CameraSensor configurations etc.. But that's yak's away at the moment: Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/ipa/mali-c55/ipa_context.h | 3 +++ > src/ipa/mali-c55/mali-c55.cpp | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/src/ipa/mali-c55/ipa_context.h b/src/ipa/mali-c55/ipa_context.h > index 2d3e91d56baa..2f2092677fbf 100644 > --- a/src/ipa/mali-c55/ipa_context.h > +++ b/src/ipa/mali-c55/ipa_context.h > @@ -10,6 +10,8 @@ > #include <libcamera/base/utils.h> > #include <libcamera/controls.h> > > +#include <libcamera/ipa/core_ipa_interface.h> > + > #include "libcamera/internal/bayer_format.h" > > #include <libipa/camera_sensor_helper.h> > @@ -82,6 +84,7 @@ struct IPAContext { > { > } > > + IPACameraSensorInfo sensorInfo; > IPASessionConfiguration configuration; > IPAActiveState activeState; > > diff --git a/src/ipa/mali-c55/mali-c55.cpp b/src/ipa/mali-c55/mali-c55.cpp > index c35cc10bea01..1e49f8bfd5ca 100644 > --- a/src/ipa/mali-c55/mali-c55.cpp > +++ b/src/ipa/mali-c55/mali-c55.cpp > @@ -98,6 +98,8 @@ std::string IPAMaliC55::logPrefix() const > int IPAMaliC55::init(const IPASettings &settings, const IPAConfigInfo &ipaConfig, > ControlInfoMap *ipaControls) > { > + context_.sensorInfo = ipaConfig.sensorInfo; > + > context_.camHelper = CameraSensorHelperFactoryBase::create(settings.sensorModel); > if (!context_.camHelper) { > LOG(IPAMaliC55, Error) > > -- > 2.54.0 >
On 15/06/2026 15:05, Jacopo Mondi wrote: > Store the sensorInfo in the IPAContext. It will be used by the Lsc > algorithm to support polynomial LSC tables. > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> > --- > src/ipa/mali-c55/ipa_context.h | 3 +++ > src/ipa/mali-c55/mali-c55.cpp | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/src/ipa/mali-c55/ipa_context.h b/src/ipa/mali-c55/ipa_context.h > index 2d3e91d56baa..2f2092677fbf 100644 > --- a/src/ipa/mali-c55/ipa_context.h > +++ b/src/ipa/mali-c55/ipa_context.h > @@ -10,6 +10,8 @@ > #include <libcamera/base/utils.h> > #include <libcamera/controls.h> > > +#include <libcamera/ipa/core_ipa_interface.h> > + > #include "libcamera/internal/bayer_format.h" > > #include <libipa/camera_sensor_helper.h> > @@ -82,6 +84,7 @@ struct IPAContext { > { > } > > + IPACameraSensorInfo sensorInfo; > IPASessionConfiguration configuration; > IPAActiveState activeState; > > diff --git a/src/ipa/mali-c55/mali-c55.cpp b/src/ipa/mali-c55/mali-c55.cpp > index c35cc10bea01..1e49f8bfd5ca 100644 > --- a/src/ipa/mali-c55/mali-c55.cpp > +++ b/src/ipa/mali-c55/mali-c55.cpp > @@ -98,6 +98,8 @@ std::string IPAMaliC55::logPrefix() const > int IPAMaliC55::init(const IPASettings &settings, const IPAConfigInfo &ipaConfig, > ControlInfoMap *ipaControls) > { > + context_.sensorInfo = ipaConfig.sensorInfo; > + > context_.camHelper = CameraSensorHelperFactoryBase::create(settings.sensorModel); > if (!context_.camHelper) { > LOG(IPAMaliC55, Error) >
diff --git a/src/ipa/mali-c55/ipa_context.h b/src/ipa/mali-c55/ipa_context.h index 2d3e91d56baa..2f2092677fbf 100644 --- a/src/ipa/mali-c55/ipa_context.h +++ b/src/ipa/mali-c55/ipa_context.h @@ -10,6 +10,8 @@ #include <libcamera/base/utils.h> #include <libcamera/controls.h> +#include <libcamera/ipa/core_ipa_interface.h> + #include "libcamera/internal/bayer_format.h" #include <libipa/camera_sensor_helper.h> @@ -82,6 +84,7 @@ struct IPAContext { { } + IPACameraSensorInfo sensorInfo; IPASessionConfiguration configuration; IPAActiveState activeState; diff --git a/src/ipa/mali-c55/mali-c55.cpp b/src/ipa/mali-c55/mali-c55.cpp index c35cc10bea01..1e49f8bfd5ca 100644 --- a/src/ipa/mali-c55/mali-c55.cpp +++ b/src/ipa/mali-c55/mali-c55.cpp @@ -98,6 +98,8 @@ std::string IPAMaliC55::logPrefix() const int IPAMaliC55::init(const IPASettings &settings, const IPAConfigInfo &ipaConfig, ControlInfoMap *ipaControls) { + context_.sensorInfo = ipaConfig.sensorInfo; + context_.camHelper = CameraSensorHelperFactoryBase::create(settings.sensorModel); if (!context_.camHelper) { LOG(IPAMaliC55, Error)
Store the sensorInfo in the IPAContext. It will be used by the Lsc algorithm to support polynomial LSC tables. Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> --- src/ipa/mali-c55/ipa_context.h | 3 +++ src/ipa/mali-c55/mali-c55.cpp | 2 ++ 2 files changed, 5 insertions(+)