| Message ID | 20260519105628.1792018-1-stefan.klug@ideasonboard.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series |
|
| Related | show |
On Tue, May 19, 2026 at 12:54:42PM +0200, Stefan Klug wrote: > With gcc 14.3.0 I hit -Werror=redundant-move on that line. Drop the > unnecessary move. Commit 17681b75f7bad1ab80f2bd091691e1d15f7438ca disables the redundant-move warningfor gcc 11 and newer. Am I missing something ? Are you running an old libcamera ? > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> > --- > src/py/libcamera/py_helpers.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/py/libcamera/py_helpers.cpp b/src/py/libcamera/py_helpers.cpp > index b9142225c0b1..2c8e15d08c0c 100644 > --- a/src/py/libcamera/py_helpers.cpp > +++ b/src/py/libcamera/py_helpers.cpp > @@ -25,7 +25,7 @@ static py::object valueOrTuple(const ControlValue &cv) > for (size_t i = 0; i < cv.numElements(); ++i) > t[i] = v[i]; > > - return std::move(t); > + return t; > } > > return py::cast(cv.get<T>());
Hi Laurent, Quoting Laurent Pinchart (2026-05-19 13:11:21) > On Tue, May 19, 2026 at 12:54:42PM +0200, Stefan Klug wrote: > > With gcc 14.3.0 I hit -Werror=redundant-move on that line. Drop the > > unnecessary move. > > Commit 17681b75f7bad1ab80f2bd091691e1d15f7438ca disables the > redundant-move warningfor gcc 11 and newer. Am I missing something ? Are > you running an old libcamera ? I'm running a reasonable new libcamera. Turned out to be an issue with meson (the cache?). A new setup of the build directory fixed the issue. So the patch can be ignored. Regards, Stefan > > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> > > --- > > src/py/libcamera/py_helpers.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/py/libcamera/py_helpers.cpp b/src/py/libcamera/py_helpers.cpp > > index b9142225c0b1..2c8e15d08c0c 100644 > > --- a/src/py/libcamera/py_helpers.cpp > > +++ b/src/py/libcamera/py_helpers.cpp > > @@ -25,7 +25,7 @@ static py::object valueOrTuple(const ControlValue &cv) > > for (size_t i = 0; i < cv.numElements(); ++i) > > t[i] = v[i]; > > > > - return std::move(t); > > + return t; > > } > > > > return py::cast(cv.get<T>()); > > -- > Regards, > > Laurent Pinchart
diff --git a/src/py/libcamera/py_helpers.cpp b/src/py/libcamera/py_helpers.cpp index b9142225c0b1..2c8e15d08c0c 100644 --- a/src/py/libcamera/py_helpers.cpp +++ b/src/py/libcamera/py_helpers.cpp @@ -25,7 +25,7 @@ static py::object valueOrTuple(const ControlValue &cv) for (size_t i = 0; i < cv.numElements(); ++i) t[i] = v[i]; - return std::move(t); + return t; } return py::cast(cv.get<T>());
With gcc 14.3.0 I hit -Werror=redundant-move on that line. Drop the unnecessary move. Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> --- src/py/libcamera/py_helpers.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)