[v2,1/3] libcamera: software_isp: Drop redundant sumShift_ guard in finishFrame
diff mbox series

Message ID 20260508171720.9B9D61EA006C@mailuser.phl.internal
State New
Headers show
Series
  • ipa: simple: OV2740 tuning file and swstats sumShift cleanup
Related show

Commit Message

Javier Tia May 8, 2026, 4:51 p.m. UTC 
Right-shifting by zero is a no-op, so the if (sumShift_) check before
the three >>= sumShift_ assignments is unnecessary. Remove it.

Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Suggested-by: Barnabas Pocze <barnabas.pocze@ideasonboard.com>
Signed-off-by: Javier Tia <floss@jetm.me>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/software_isp/swstats_cpu.cpp | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Patch
diff mbox series 

diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp
index b40d3334..2e020e62 100644
--- a/src/libcamera/software_isp/swstats_cpu.cpp
+++ b/src/libcamera/software_isp/swstats_cpu.cpp
@@ -362,11 +362,10 @@  void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId)
 			for (unsigned int j = 0; j < SwIspStats::kYHistogramSize; j++)
 				sharedStats_->yHistogram[j] += s.yHistogram[j];
 		}
-		if (sumShift_) {
-			sharedStats_->sum_.r() >>= sumShift_;
-			sharedStats_->sum_.g() >>= sumShift_;
-			sharedStats_->sum_.b() >>= sumShift_;
-		}
+
+		sharedStats_->sum_.r() >>= sumShift_;
+		sharedStats_->sum_.g() >>= sumShift_;
+		sharedStats_->sum_.b() >>= sumShift_;
 	}
 
 	sharedStats_->valid = valid;