[v2,40/42] libcamera: software_isp: Rename "measure" option to "benchmark"
diff mbox series

Message ID 20260407153427.1825999-41-laurent.pinchart@ideasonboard.com
State New
Headers show
Series
  • libcamera: Global configuration file improvements
Related show

Commit Message

Laurent Pinchart April 7, 2026, 3:34 p.m. UTC 
The software ISP "measure" configuration option doesn't clearly indicate
what it measures. Rename it to "benchmark" to match the name of the
class that handles it and make it self-explicit.

While at it, improve the documentation slightly by replacing "per-frame
time measurement" with "performance measurement".

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 Documentation/runtime_configuration.rst  | 10 +++++-----
 src/libcamera/software_isp/benchmark.cpp | 10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

Patch
diff mbox series 

diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst
index 2cdffb335a66..fa7fb34f8eff 100644
--- a/Documentation/runtime_configuration.rst
+++ b/Documentation/runtime_configuration.rst
@@ -48,7 +48,7 @@  file structure:
             software_isp: # true/false
     software_isp:
       copy_input_buffer: # true/false
-      measure:
+      benchmark:
         skip: # non-negative integer, frames to skip initially
         number: # non-negative integer, frames to measure
       mode: # cpu/gpu
@@ -83,7 +83,7 @@  Configuration file example
              software_isp: true
      software_isp:
        copy_input_buffer: false
-       measure:
+       benchmark:
          skip: 50
          number: 30
        mode: gpu
@@ -166,13 +166,13 @@  software_isp.copy_input_buffer
 
    Example value: ``false``
 
-software_isp.measure.skip, software_isp.measure.number
-   Define per-frame time measurement parameters in software ISP. `skip`
+software_isp.benchmark.skip, software_isp.benchmark.number
+   Define performance measurement parameters for the software ISP. `skip`
    defines how many initial frames are skipped before starting the
    measurement; `number` defines how many frames then participate in the
    measurement.
 
-   Set `software_isp.measure.number` to 0 to disable the measurement.
+   Set `software_isp.benchmark.number` to 0 to disable the measurement.
 
    Example `skip` value: ``50``
 
diff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp
index 96f0ae004563..22cc8cfb984e 100644
--- a/src/libcamera/software_isp/benchmark.cpp
+++ b/src/libcamera/software_isp/benchmark.cpp
@@ -35,11 +35,11 @@  Benchmark::Benchmark(const CameraManager &cm, const std::string &name)
 	const GlobalConfiguration &configuration = cm._d()->configuration();
 
 	skipBeforeMeasure_ = configuration.option<unsigned int>(
-						{ "software_isp", "measure", "skip" })
-							.value_or(skipBeforeMeasure_);
-	framesToMeasure_ = configuration.option<unsigned int>(
-						{ "software_isp", "measure", "number" })
-							.value_or(framesToMeasure_);
+						{ "software_isp", "benchmark", "skip" })
+					  .value_or(skipBeforeMeasure_);
+        framesToMeasure_ = configuration.option<unsigned int>(
+						{ "software_isp", "benchmark", "number" })
+					.value_or(framesToMeasure_);
 }
 
 Benchmark::~Benchmark()