[2/2] egl: Switch to linux/drm_fourcc.h
diff mbox series

Message ID 20260331234644.14654-3-bryan.odonoghue@linaro.org
State New
Headers show
Series
  • Import drm.h and drm_mode.h for egl.cpp to use
Related show

Commit Message

Bryan O'Donoghue March 31, 2026, 11:46 p.m. UTC 
Take the copy of drm_fourcc.h from th imported kernel headers instead of
from libdrm which may or may not be installed within the build environment.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 src/libcamera/egl.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Jacopo Mondi April 1, 2026, 7:31 a.m. UTC | #1 
Hi Bryan

On Wed, Apr 01, 2026 at 12:46:44AM +0100, Bryan O'Donoghue wrote:
> Take the copy of drm_fourcc.h from th imported kernel headers instead of
> from libdrm which may or may not be installed within the build environment.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  src/libcamera/egl.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp
> index 5b9bbf410..a61803396 100644
> --- a/src/libcamera/egl.cpp
> +++ b/src/libcamera/egl.cpp

This seems to be indeed the only user of this header in the whole code
base

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
  j

> @@ -16,11 +16,10 @@
>
>  #include <linux/dma-buf.h>
>  #include <linux/dma-heap.h>
> +#include <linux/drm_fourcc.h>
>
>  #include <libcamera/base/thread.h>
>
> -#include <libdrm/drm_fourcc.h>
> -
>  namespace libcamera {
>
>  LOG_DEFINE_CATEGORY(eGL)
> --
> 2.52.0
>
Laurent Pinchart April 1, 2026, 7:35 a.m. UTC | #2 
On Wed, Apr 01, 2026 at 12:46:44AM +0100, Bryan O'Donoghue wrote:
> Take the copy of drm_fourcc.h from th imported kernel headers instead of

s/from th/from the/

> from libdrm which may or may not be installed within the build environment.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/egl.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp
> index 5b9bbf410..a61803396 100644
> --- a/src/libcamera/egl.cpp
> +++ b/src/libcamera/egl.cpp
> @@ -16,11 +16,10 @@
>  
>  #include <linux/dma-buf.h>
>  #include <linux/dma-heap.h>
> +#include <linux/drm_fourcc.h>
>  
>  #include <libcamera/base/thread.h>
>  
> -#include <libdrm/drm_fourcc.h>
> -
>  namespace libcamera {
>  
>  LOG_DEFINE_CATEGORY(eGL)

Patch
diff mbox series 

diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp
index 5b9bbf410..a61803396 100644
--- a/src/libcamera/egl.cpp
+++ b/src/libcamera/egl.cpp
@@ -16,11 +16,10 @@ 
 
 #include <linux/dma-buf.h>
 #include <linux/dma-heap.h>
+#include <linux/drm_fourcc.h>
 
 #include <libcamera/base/thread.h>
 
-#include <libdrm/drm_fourcc.h>
-
 namespace libcamera {
 
 LOG_DEFINE_CATEGORY(eGL)