[v3,3/3] libcamera: software_isp: Fix LIBCAMERA_SOFTISP_MODE log print
diff mbox series

Message ID 20260218-kbingham-awb-cleanup-v3-3-3be1269ef949@ideasonboard.com
State Accepted
Commit da12b1854fbc0ec32d3162a0ab97654fcb679ae3
Headers show
Series
  • ipa: awb: Fix and cleanup RKISP1 and Simple Awb
Related show

Commit Message

Kieran Bingham Feb. 18, 2026, 4:42 p.m. UTC 
When an invalid parameter is specified to LIBCAMERA_SOFTISP_MODE, the
error log has a typo. Fix the typo and reflow the line while here.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

---
v3:
 - Collect tags,
 - Clean up log message to Laurent's preference
---
 src/libcamera/software_isp/software_isp.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Patch
diff mbox series 

diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
index a83986b787b7..c2baaf0bf276 100644
--- a/src/libcamera/software_isp/software_isp.cpp
+++ b/src/libcamera/software_isp/software_isp.cpp
@@ -108,8 +108,10 @@  SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,
 	std::optional<std::string> softISPMode = configuration.envOption("LIBCAMERA_SOFTISP_MODE", { "software_isp", "mode" });
 	if (softISPMode) {
 		if (softISPMode != "gpu" && softISPMode != "cpu") {
-			LOG(SoftwareIsp, Error) << "LIBCAMERA_SOFISP_MODE " << softISPMode.value() << " invalid "
-						<< "must be \"cpu\" or \"gpu\"";
+			LOG(SoftwareIsp, Error)
+				<< "Invalid LIBCAMERA_SOFTISP_MODE \""
+				<< softISPMode.value()
+				<< "\", must be \"cpu\" or \"gpu\"";
 			return;
 		}
 	}