[v2] meson: Add `apps-output-dng` option to control libtiff dependency

26162 diff mbox series

Previously it was not possible to disable the use of libtiff in the cam
and qcam applications if it was detected. Fix that by adding a meson
feature option.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
changes in v2:
  * rename option

v1: https://patchwork.libcamera.org/patch/26056/
---
 meson_options.txt    | 5 +++++
 src/apps/meson.build | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

--
2.53.0

Hi all

I would like to merge this change. Any comments?


2026. 02. 16. 16:11 keltezéssel, Barnabás Pőcze írta:
> Previously it was not possible to disable the use of libtiff in the cam
> and qcam applications if it was detected. Fix that by adding a meson
> feature option.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
> changes in v2:
>    * rename option
> 
> v1: https://patchwork.libcamera.org/patch/26056/
> ---
>   meson_options.txt    | 5 +++++
>   src/apps/meson.build | 2 +-
>   2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/meson_options.txt b/meson_options.txt
> index c27e377ad..f1dbfcee5 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -11,6 +11,11 @@ option('android_platform',
>           value : 'generic',
>           description : 'Select the Android platform to compile for')
> 
> +option('apps-output-dng',
> +        type : 'feature',
> +        value : 'auto',
> +        description : 'Enable DNG file creation support in the cam and qcam applications')
> +
>   option('cam',
>           type : 'feature',
>           value : 'auto',
> diff --git a/src/apps/meson.build b/src/apps/meson.build
> index af632b9a7..bc3a79196 100644
> --- a/src/apps/meson.build
> +++ b/src/apps/meson.build
> @@ -10,7 +10,7 @@ if not libevent.found()
>       libevent = dependency('libevent_pthreads', required : opt_lc_compliance)
>   endif
> 
> -libtiff = dependency('libtiff-4', required : false)
> +libtiff = dependency('libtiff-4', required : get_option('apps-output-dng'))
> 
>   subdir('common')
> 
> --
> 2.53.0

Quoting Barnabás Pőcze (2026-03-23 08:10:27)
> Hi all
> 
> I would like to merge this change. Any comments?

I think it's fine to merge.

--
Kieran


> 
> 
> 2026. 02. 16. 16:11 keltezéssel, Barnabás Pőcze írta:
> > Previously it was not possible to disable the use of libtiff in the cam
> > and qcam applications if it was detected. Fix that by adding a meson
> > feature option.
> > 
> > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> > ---
> > changes in v2:
> >    * rename option
> > 
> > v1: https://patchwork.libcamera.org/patch/26056/
> > ---
> >   meson_options.txt    | 5 +++++
> >   src/apps/meson.build | 2 +-
> >   2 files changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meson_options.txt b/meson_options.txt
> > index c27e377ad..f1dbfcee5 100644
> > --- a/meson_options.txt
> > +++ b/meson_options.txt
> > @@ -11,6 +11,11 @@ option('android_platform',
> >           value : 'generic',
> >           description : 'Select the Android platform to compile for')
> > 
> > +option('apps-output-dng',
> > +        type : 'feature',
> > +        value : 'auto',
> > +        description : 'Enable DNG file creation support in the cam and qcam applications')
> > +
> >   option('cam',
> >           type : 'feature',
> >           value : 'auto',
> > diff --git a/src/apps/meson.build b/src/apps/meson.build
> > index af632b9a7..bc3a79196 100644
> > --- a/src/apps/meson.build
> > +++ b/src/apps/meson.build
> > @@ -10,7 +10,7 @@ if not libevent.found()
> >       libevent = dependency('libevent_pthreads', required : opt_lc_compliance)
> >   endif
> > 
> > -libtiff = dependency('libtiff-4', required : false)
> > +libtiff = dependency('libtiff-4', required : get_option('apps-output-dng'))
> > 
> >   subdir('common')
> > 
> > --
> > 2.53.0
>