[v13,7/7] ipa: rkisp1: algorithms: data: Add IMX219 Dpf into tuning file
diff mbox

Message ID 20260206151205.143671-8-rui.wang@ideasonboard.com
State New
Headers show

Commit Message

Rui Wang Feb. 6, 2026, 3:12 p.m. UTC
This includes initial settings for DPF algorithms.

Add Dpf tuning config into Imx219

Signed-off-by: Rui Wang <rui.wang@ideasonboard.com>

---
 changelog since v7 :
  - move imx219 dpf tuning config
  - update tuning parameters since "key" update

 changelog since v9:
  - Update dpf tuning config regarding reduction mode format
    from  list to dictionary
  - add ActiveMode for dpf default mode

 changelog since v10:
  - Modify ReductionMinimal - > NoiseReductionModeMinimal
  since parser code update
 changelog since v11:
  - Change  "ActiveMode" to "activeMode"

 changelog since v12:
  - delete ov5647 tuning config
  - delete build config for ov5647
---
 src/ipa/rkisp1/data/imx219.yaml | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Comments

Jacopo Mondi Feb. 8, 2026, 1:52 p.m. UTC | #1
Hi Rui
  for the commit title:

ipa: rkisp1: imx219: Add Dpf tuning data

On Fri, Feb 06, 2026 at 10:12:05AM -0500, Rui Wang wrote:
> This includes initial settings for DPF algorithms.

Add Dpf tuning data to the RkISP1 version of the imx219 tuning file.

Add support for two configuration modes and enable the "HighQuality"
one by default.

>
> Add Dpf tuning config into Imx219
>
> Signed-off-by: Rui Wang <rui.wang@ideasonboard.com>

Acked-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

>
> ---
>  changelog since v7 :
>   - move imx219 dpf tuning config
>   - update tuning parameters since "key" update
>
>  changelog since v9:
>   - Update dpf tuning config regarding reduction mode format
>     from  list to dictionary
>   - add ActiveMode for dpf default mode
>
>  changelog since v10:
>   - Modify ReductionMinimal - > NoiseReductionModeMinimal
>   since parser code update
>  changelog since v11:
>   - Change  "ActiveMode" to "activeMode"
>
>  changelog since v12:
>   - delete ov5647 tuning config
>   - delete build config for ov5647
> ---
>  src/ipa/rkisp1/data/imx219.yaml | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml
> index 0d99cb52..e8d2acbb 100644
> --- a/src/ipa/rkisp1/data/imx219.yaml
> +++ b/src/ipa/rkisp1/data/imx219.yaml
> @@ -111,4 +111,29 @@ algorithms:
>                 1438, 1226, 1059, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1025, 1054, 1185,
>                 1326, 1334, 1334,
>               ]
> +  - Dpf:
> +      NoiseReductionModes:
> +        NoiseReductionModeMinimal:
> +          DomainFilter:
> +            g:  [ 14, 10,  7,  4,  2,  1 ]
> +            rb: [ 14, 11,  8,  4,  2,  1 ]
> +          NoiseLevelFunction:
> +            coeff: [ 0, 26, 52, 78, 106, 138, 172, 208, 248, 292, 340, 392, 448, 508, 572, 640, 712 ]
> +            scale-mode: "linear"
> +          FilterStrength:
> +            r: 60
> +            g: 60
> +            b: 60
> +        NoiseReductionModeHighQuality:
> +          DomainFilter:
> +            g:  [ 22, 18, 13,  8,  5,  2 ]
> +            rb: [ 20, 18, 16, 11,  7,  3 ]
> +          NoiseLevelFunction:
> +            coeff: [ 0, 26, 52, 78, 106, 138, 172, 208, 248, 292, 340, 392, 448, 508, 572, 640, 712 ]
> +            scale-mode: "linear"
> +          FilterStrength:
> +            r: 130
> +            g: 130
> +            b: 130
> +      activeMode: "NoiseReductionModeHighQuality"
>  ...
> --
> 2.43.0
>

Patch
diff mbox

diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml
index 0d99cb52..e8d2acbb 100644
--- a/src/ipa/rkisp1/data/imx219.yaml
+++ b/src/ipa/rkisp1/data/imx219.yaml
@@ -111,4 +111,29 @@  algorithms:
                1438, 1226, 1059, 1024, 1024, 1024, 1024, 1024, 1024, 1024, 1025, 1054, 1185,
                1326, 1334, 1334,
              ]
+  - Dpf:
+      NoiseReductionModes:
+        NoiseReductionModeMinimal:
+          DomainFilter:
+            g:  [ 14, 10,  7,  4,  2,  1 ]
+            rb: [ 14, 11,  8,  4,  2,  1 ]
+          NoiseLevelFunction:
+            coeff: [ 0, 26, 52, 78, 106, 138, 172, 208, 248, 292, 340, 392, 448, 508, 572, 640, 712 ]
+            scale-mode: "linear"
+          FilterStrength:
+            r: 60
+            g: 60
+            b: 60
+        NoiseReductionModeHighQuality:
+          DomainFilter:
+            g:  [ 22, 18, 13,  8,  5,  2 ]
+            rb: [ 20, 18, 16, 11,  7,  3 ]
+          NoiseLevelFunction:
+            coeff: [ 0, 26, 52, 78, 106, 138, 172, 208, 248, 292, 340, 392, 448, 508, 572, 640, 712 ]
+            scale-mode: "linear"
+          FilterStrength:
+            r: 130
+            g: 130
+            b: 130
+      activeMode: "NoiseReductionModeHighQuality"
 ...