[v6,14/15] libcamera: control_ids: Introduce LensShadingCorrectionEnable
diff mbox series

Message ID 20260128-sklug-lsc-resampling-v2-dev-v6-14-af7d95f03d22@ideasonboard.com
State Accepted
Headers show
Series
  • Add resampling support for polynomial LSC data
Related show

Commit Message

Stefan Klug Jan. 28, 2026, 4 p.m. UTC 
Introduce a LensShadingCorrectionEnable control to enable and disable
LSC. This is useful to assess the working and quality of the lens
shading correction at runtime.

While at it drop the reference to the tuning file in the description of
the LensDewarpEnable control, as that information doesn't belong to the
controls.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

---

Changes in v6:
- Improved the control description
- Dropped the reference to the tuning file
- Collected tags

Changes in v5:
- Readd this patch to have a separate patch for the control id
- Dropped android specific changes

Changes in v2:
- Renamed LensShadingEnable to LensShadingCorrectionEnable
- Fixed android code to properly handle the boolean value
- Added "only if tuned" info sentence to the control description
---
 src/libcamera/control_ids_core.yaml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Patch
diff mbox series 

diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml
index 8e99bd84825f6060dbc323be3f4b0cd6283e0942..f26a1b1b08bd1684cb76d75ecc32bdb9f8b0f6e5 100644
--- a/src/libcamera/control_ids_core.yaml
+++ b/src/libcamera/control_ids_core.yaml
@@ -1353,7 +1353,12 @@  controls:
       type: bool
       direction: inout
       description: |
-        Enable or disable lens dewarping. This control is only available if lens
-        dewarp parameters are configured in the tuning file.
+        Enable or disable lens dewarping.
+
+  - LensShadingCorrectionEnable:
+      type: bool
+      direction: inout
+      description: |
+        Enable or disable the lens shading correction.
 
 ...