[v4,12/15] libcamera: ipa: simple: Use symbolic constants for adjust defaults
diff mbox series

Message ID 20260122161935.208562-13-mzamazal@redhat.com
State New
Headers show
Series
  • Simple pipeline IPA cleanup
Related show

Commit Message

Milan Zamazal Jan. 22, 2026, 4:19 p.m. UTC 
The adjust algorithm already uses a symbolic constant for gamma.  Let's
introduce similar constants for contrast and saturation to prevent
copying the numeric defaults to multiple places.

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
---
 src/ipa/simple/algorithms/adjust.cpp | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

Patch
diff mbox series 

diff --git a/src/ipa/simple/algorithms/adjust.cpp b/src/ipa/simple/algorithms/adjust.cpp
index a8b7c5ab6..23f6f6ad7 100644
--- a/src/ipa/simple/algorithms/adjust.cpp
+++ b/src/ipa/simple/algorithms/adjust.cpp
@@ -1,7 +1,7 @@ 
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 /*
  * Copyright (C) 2024, Ideas On Board
- * Copyright (C) 2024-2025, Red Hat Inc.
+ * Copyright (C) 2024-2026, Red Hat Inc.
  *
  * Common image adjustments
  */
@@ -19,14 +19,20 @@  namespace libcamera {
 
 namespace ipa::soft::algorithms {
 
+constexpr float kDefaultContrast = 1.0f;
+constexpr float kDefaultSaturation = 1.0f;
+
 LOG_DEFINE_CATEGORY(IPASoftAdjust)
 
 int Adjust::init(IPAContext &context, [[maybe_unused]] const YamlObject &tuningData)
 {
-	context.ctrlMap[&controls::Gamma] = ControlInfo(0.1f, 10.0f, kDefaultGamma);
-	context.ctrlMap[&controls::Contrast] = ControlInfo(0.0f, 2.0f, 1.0f);
+	context.ctrlMap[&controls::Gamma] =
+		ControlInfo(0.1f, 10.0f, kDefaultGamma);
+	context.ctrlMap[&controls::Contrast] =
+		ControlInfo(0.0f, 2.0f, kDefaultContrast);
 	if (context.ccmEnabled)
-		context.ctrlMap[&controls::Saturation] = ControlInfo(0.0f, 2.0f, 1.0f);
+		context.ctrlMap[&controls::Saturation] =
+			ControlInfo(0.0f, 2.0f, kDefaultSaturation);
 	return 0;
 }
 
@@ -122,7 +128,7 @@  void Adjust::process([[maybe_unused]] IPAContext &context,
 		metadata.set(controls::Contrast, contrast.value());
 
 	const auto &saturation = frameContext.saturation;
-	metadata.set(controls::Saturation, saturation.value_or(1.0));
+	metadata.set(controls::Saturation, saturation.value_or(kDefaultSaturation));
 }
 
 REGISTER_IPA_ALGORITHM(Adjust, "Adjust")