| Message ID | 20260121173737.376113-11-kieran.bingham@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Kieran Bingham (2026-01-21 18:37:29) > Replace the legacy call to floatingToFixedPoint with the new FixedPoint > quantizer to explicitly describe the type used by the RKISP1 Colour > Correction Matrix. > > Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com> > Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > --- > v5: > - Use Q<4, 7> > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/ipa/rkisp1/algorithms/ccm.cpp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp > index de2b6fe775aa..466d7a116eea 100644 > --- a/src/ipa/rkisp1/algorithms/ccm.cpp > +++ b/src/ipa/rkisp1/algorithms/ccm.cpp > @@ -117,8 +117,7 @@ void Ccm::setParameters(struct rkisp1_cif_isp_ctk_config &config, > */ > for (unsigned int i = 0; i < 3; i++) { > for (unsigned int j = 0; j < 3; j++) > - config.coeff[i][j] = > - floatingToFixedPoint<4, 7, uint16_t, double>(matrix[i][j]); > + config.coeff[i][j] = Q<4, 7>(matrix[i][j]).quantized(); Yep, that is all fine now. Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> Cheers, Stefan > } > > for (unsigned int i = 0; i < 3; i++) > -- > 2.52.0 >
diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp index de2b6fe775aa..466d7a116eea 100644 --- a/src/ipa/rkisp1/algorithms/ccm.cpp +++ b/src/ipa/rkisp1/algorithms/ccm.cpp @@ -117,8 +117,7 @@ void Ccm::setParameters(struct rkisp1_cif_isp_ctk_config &config, */ for (unsigned int i = 0; i < 3; i++) { for (unsigned int j = 0; j < 3; j++) - config.coeff[i][j] = - floatingToFixedPoint<4, 7, uint16_t, double>(matrix[i][j]); + config.coeff[i][j] = Q<4, 7>(matrix[i][j]).quantized(); } for (unsigned int i = 0; i < 3; i++)