[1/3] pipeline: virtual: image_frame_generator: Explicitly include libcamera headers
diff mbox series

Message ID 20260121090705.274081-2-uajain@igalia.com
State New
Headers show
Series
  • virtual: colorspace validation fix
Related show

Commit Message

Umang Jain Jan. 21, 2026, 9:07 a.m. UTC
Directly include libcamera headers instead of including them indirectly
via frame_generator.h.

Signed-off-by: Umang Jain <uajain@igalia.com>
---
 src/libcamera/pipeline/virtual/image_frame_generator.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Barnabás Pőcze Jan. 21, 2026, 9:36 a.m. UTC | #1
2026. 01. 21. 10:07 keltezéssel, Umang Jain írta:
> Directly include libcamera headers instead of including them indirectly
> via frame_generator.h.
> 
> Signed-off-by: Umang Jain <uajain@igalia.com>
> ---

Looks ok.

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   src/libcamera/pipeline/virtual/image_frame_generator.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/src/libcamera/pipeline/virtual/image_frame_generator.h b/src/libcamera/pipeline/virtual/image_frame_generator.h
> index 42a077ba..851ddbc0 100644
> --- a/src/libcamera/pipeline/virtual/image_frame_generator.h
> +++ b/src/libcamera/pipeline/virtual/image_frame_generator.h
> @@ -13,6 +13,9 @@
>   #include <sys/types.h>
>   #include <vector>
>   
> +#include <libcamera/framebuffer.h>
> +#include <libcamera/geometry.h>
> +
>   #include "frame_generator.h"
>   
>   namespace libcamera {

Patch
diff mbox series

diff --git a/src/libcamera/pipeline/virtual/image_frame_generator.h b/src/libcamera/pipeline/virtual/image_frame_generator.h
index 42a077ba..851ddbc0 100644
--- a/src/libcamera/pipeline/virtual/image_frame_generator.h
+++ b/src/libcamera/pipeline/virtual/image_frame_generator.h
@@ -13,6 +13,9 @@ 
 #include <sys/types.h>
 #include <vector>
 
+#include <libcamera/framebuffer.h>
+#include <libcamera/geometry.h>
+
 #include "frame_generator.h"
 
 namespace libcamera {