[libcamera-ci,RFC,v1,5/5] Guard jobs required for hardware testing

25844 diff mbox series

Use manually triggered jobs.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 gitlab-ci.yml | 9 +++++++++
 1 file changed, 9 insertions(+)

--
2.52.0

On Mon, Jan 19, 2026 at 11:20:39AM +0100, Barnabás Pőcze wrote:
> Use manually triggered jobs.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
>  gitlab-ci.yml | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/gitlab-ci.yml b/gitlab-ci.yml
> index 8f670f7..40a42f0 100644
> --- a/gitlab-ci.yml
> +++ b/gitlab-ci.yml
> @@ -58,6 +58,10 @@ include:
>      ref: *templates_sha
>      file: '/templates/debian.yml'
> 
> +.on-device-testing-guard:
> +  rules:
> +    - when: manual

Could we trigger this based on a variable passed as a push option
instead ? That would avoid having to interact with the web UI.

> +
>  .libcamera-ci.debian:11:
>    variables:
>      FDO_DISTRIBUTION_VERSION: 'bullseye'
> @@ -421,6 +425,7 @@ build-debian-cross:
>      - .fdo.distribution-image@debian
>      - .debian-cross-build
>      - .debian-cross-build-architectures
> +    - .on-device-testing-guard
>    stage: build
>    needs:
>      - job: container-build-debian-cross
> @@ -469,6 +474,7 @@ build-debian-rootfs:
>      - .debian-cross-build
>      - .debian-cross-build-architectures
>      - .libcamera-ci.scripts
> +    - .on-device-testing-guard
>    stage: build
>    needs:
>      - job: container-build-debian-rootfs
> @@ -488,6 +494,7 @@ lava-jobs-as-artifacts:
>      - .fdo.distribution-image@debian
>      - .container-build-debian-rootfs
>      - .libcamera-ci.scripts
> +    - .on-device-testing-guard
>    stage: build
>    needs:
>      - job: container-build-debian-rootfs
> @@ -605,6 +612,8 @@ test-lc-compliance:virtual:
>        junit: build/lc-compliance-report.xml
> 
>  test-lc-compliance:rkisp1:debix-a:
> +  extends:
> +    - .on-device-testing-guard
>    stage: test
>    needs:
>      - job: lava-jobs-as-artifacts

Hi


2026. 01. 22. 3:28 keltezéssel, Laurent Pinchart írta:
> On Mon, Jan 19, 2026 at 11:20:39AM +0100, Barnabás Pőcze wrote:
>> Use manually triggered jobs.
>>
>> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
>> ---
>>   gitlab-ci.yml | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/gitlab-ci.yml b/gitlab-ci.yml
>> index 8f670f7..40a42f0 100644
>> --- a/gitlab-ci.yml
>> +++ b/gitlab-ci.yml
>> @@ -58,6 +58,10 @@ include:
>>       ref: *templates_sha
>>       file: '/templates/debian.yml'
>>
>> +.on-device-testing-guard:
>> +  rules:
>> +    - when: manual
> 
> Could we trigger this based on a variable passed as a push option
> instead ? That would avoid having to interact with the web UI.

Maybe I am misremembering, but I gathered from the latest discussions that this
was preferable? I seem to recall that it was useful to be able to start it later
without having to push again. In any case I believe another rule can be added so
that the jobs start: if started manually OR if there is a certain variable defined.
Does that sound reasonable?


> 
>> +
>>   .libcamera-ci.debian:11:
>>     variables:
>>       FDO_DISTRIBUTION_VERSION: 'bullseye'
>> @@ -421,6 +425,7 @@ build-debian-cross:
>>       - .fdo.distribution-image@debian
>>       - .debian-cross-build
>>       - .debian-cross-build-architectures
>> +    - .on-device-testing-guard
>>     stage: build
>>     needs:
>>       - job: container-build-debian-cross
>> @@ -469,6 +474,7 @@ build-debian-rootfs:
>>       - .debian-cross-build
>>       - .debian-cross-build-architectures
>>       - .libcamera-ci.scripts
>> +    - .on-device-testing-guard
>>     stage: build
>>     needs:
>>       - job: container-build-debian-rootfs
>> @@ -488,6 +494,7 @@ lava-jobs-as-artifacts:
>>       - .fdo.distribution-image@debian
>>       - .container-build-debian-rootfs
>>       - .libcamera-ci.scripts
>> +    - .on-device-testing-guard
>>     stage: build
>>     needs:
>>       - job: container-build-debian-rootfs
>> @@ -605,6 +612,8 @@ test-lc-compliance:virtual:
>>         junit: build/lc-compliance-report.xml
>>
>>   test-lc-compliance:rkisp1:debix-a:
>> +  extends:
>> +    - .on-device-testing-guard
>>     stage: test
>>     needs:
>>       - job: lava-jobs-as-artifacts
>

On Thu, Jan 22, 2026 at 09:48:04AM +0100, Barnabás Pőcze wrote:
> 2026. 01. 22. 3:28 keltezéssel, Laurent Pinchart írta:
> > On Mon, Jan 19, 2026 at 11:20:39AM +0100, Barnabás Pőcze wrote:
> >> Use manually triggered jobs.
> >>
> >> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> >> ---
> >>   gitlab-ci.yml | 9 +++++++++
> >>   1 file changed, 9 insertions(+)
> >>
> >> diff --git a/gitlab-ci.yml b/gitlab-ci.yml
> >> index 8f670f7..40a42f0 100644
> >> --- a/gitlab-ci.yml
> >> +++ b/gitlab-ci.yml
> >> @@ -58,6 +58,10 @@ include:
> >>       ref: *templates_sha
> >>       file: '/templates/debian.yml'
> >>
> >> +.on-device-testing-guard:
> >> +  rules:
> >> +    - when: manual
> > 
> > Could we trigger this based on a variable passed as a push option
> > instead ? That would avoid having to interact with the web UI.
> 
> Maybe I am misremembering, but I gathered from the latest discussions that this
> was preferable? I seem to recall that it was useful to be able to start it later
> without having to push again.

That's a good point, it could be useful for initial testing indeed.

> In any case I believe another rule can be added so
> that the jobs start: if started manually OR if there is a certain variable defined.
> Does that sound reasonable?

I think so. I'm also fine starting with manual trigger only while we
ramp up the infrastructure.

> >> +
> >>   .libcamera-ci.debian:11:
> >>     variables:
> >>       FDO_DISTRIBUTION_VERSION: 'bullseye'
> >> @@ -421,6 +425,7 @@ build-debian-cross:
> >>       - .fdo.distribution-image@debian
> >>       - .debian-cross-build
> >>       - .debian-cross-build-architectures
> >> +    - .on-device-testing-guard
> >>     stage: build
> >>     needs:
> >>       - job: container-build-debian-cross
> >> @@ -469,6 +474,7 @@ build-debian-rootfs:
> >>       - .debian-cross-build
> >>       - .debian-cross-build-architectures
> >>       - .libcamera-ci.scripts
> >> +    - .on-device-testing-guard
> >>     stage: build
> >>     needs:
> >>       - job: container-build-debian-rootfs
> >> @@ -488,6 +494,7 @@ lava-jobs-as-artifacts:
> >>       - .fdo.distribution-image@debian
> >>       - .container-build-debian-rootfs
> >>       - .libcamera-ci.scripts
> >> +    - .on-device-testing-guard
> >>     stage: build
> >>     needs:
> >>       - job: container-build-debian-rootfs
> >> @@ -605,6 +612,8 @@ test-lc-compliance:virtual:
> >>         junit: build/lc-compliance-report.xml
> >>
> >>   test-lc-compliance:rkisp1:debix-a:
> >> +  extends:
> >> +    - .on-device-testing-guard
> >>     stage: test
> >>     needs:
> >>       - job: lava-jobs-as-artifacts