[v9,4/6] ipa: rkisp1: algorithms: dpf: Add detailed config logging
diff mbox series

Message ID 20260118203119.1554962-5-rui.wang@ideasonboard.com
State New
Headers show
Series
  • refactor DPF parsing and initialization
Related show

Commit Message

Rui Wang Jan. 18, 2026, 8:31 p.m. UTC 
Add logConfig() helper function to log DPF configuration
updates when they occur. This provides visibility into the active
DPF parameters including:

- Control mode and denoise enable state
- Filter sizes (9x9 vs 13x9 for rb)
- NLL scale mode (linear vs logarithmic)
- Gain mode
- Strength values (r, g, b)
- Spatial filter coefficients (g and rb arrays)
- Noise level lookup table coefficients

The logging is triggered in prepareEnabledMode() whenever the
configuration is updated, helping with debugging and tuning.

Signed-off-by: Rui Wang <rui.wang@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

---
changelog since v5:
 - remove curly bracket in single state if-else

 Reviewed-by tags from v5 are carried over (no function changes).

changelog since v6: No change
changelog since v8:
 - add logConfi argument : rkisp1_cif_isp_dpf_config rkisp1_cif_isp_dpf_strength_config
---
 src/ipa/rkisp1/algorithms/dpf.cpp | 51 +++++++++++++++++++++++++++++--
 src/ipa/rkisp1/algorithms/dpf.h   |  6 +++-
 2 files changed, 54 insertions(+), 3 deletions(-)

Patch
diff mbox series 

diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp
index f300d0a5..7a162f27 100644
--- a/src/ipa/rkisp1/algorithms/dpf.cpp
+++ b/src/ipa/rkisp1/algorithms/dpf.cpp
@@ -286,6 +286,49 @@  bool Dpf::loadConfig(int32_t mode)
 	return true;
 }
 
+void Dpf::logConfig(const IPAFrameContext &frameContext,
+		    const struct rkisp1_cif_isp_dpf_config &config,
+		    const struct rkisp1_cif_isp_dpf_strength_config &strengthConfig) const
+{
+	std::ostringstream ss;
+
+	ss << "DPF config update: ";
+	ss << " control mode=" << modeName(activeMode_->modeValue);
+	ss << ", denoise=" << (frameContext.dpf.denoise ? "enabled" : "disabled");
+
+	ss << ", rb_fltsize="
+	   << (config.rb_flt.fltsize == RKISP1_CIF_ISP_DPF_RB_FILTERSIZE_13x9 ? "13x9" : "9x9");
+	ss << ", nll_scale="
+	   << (config.nll.scale_mode == RKISP1_CIF_ISP_NLL_SCALE_LOGARITHMIC ? "log" : "linear");
+	ss << ", gain_mode=" << config.gain.mode;
+	ss << ", strength=" << int(strengthConfig.r) << ',' << int(strengthConfig.g) << ',' << int(strengthConfig.b);
+
+	ss << ", g=[";
+	for (size_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS; ++i) {
+		if (i)
+			ss << ',';
+		ss << int(config.g_flt.spatial_coeff[i]);
+	}
+	ss << "]";
+
+	ss << ", rb=[";
+	for (size_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS; ++i) {
+		if (i)
+			ss << ',';
+		ss << int(config.rb_flt.spatial_coeff[i]);
+	}
+	ss << "]";
+
+	ss << ", nll=[";
+	for (size_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS; ++i) {
+		if (i)
+			ss << ',';
+		ss << int(config.nll.coeff[i]);
+	}
+	ss << "]";
+	LOG(RkISP1Dpf, Debug) << ss.str();
+}
+
 /**
  * \copydoc libcamera::ipa::Algorithm::queueRequest
  */
@@ -343,7 +386,7 @@  void Dpf::prepare(IPAContext &context, const uint32_t frame,
 		return;
 	}
 
-	prepareEnabledMode(context, params);
+	prepareEnabledMode(context, frameContext, params);
 }
 
 void Dpf::prepareDisabledMode(RkISP1Params *params)
@@ -354,7 +397,8 @@  void Dpf::prepareDisabledMode(RkISP1Params *params)
 	dpfStrength.setEnabled(false);
 }
 
-void Dpf::prepareEnabledMode(IPAContext &context, RkISP1Params *params)
+void Dpf::prepareEnabledMode(IPAContext &context, IPAFrameContext &frameContext,
+			     RkISP1Params *params)
 {
 	if (activeMode_ == noiseReductionModes_.end())
 		return;
@@ -390,6 +434,9 @@  void Dpf::prepareEnabledMode(IPAContext &context, RkISP1Params *params)
 	auto strengthConfig = params->block<BlockType::DpfStrength>();
 	strengthConfig.setEnabled(true);
 	*strengthConfig = modeConfig.strength;
+
+	if (frameContext.dpf.update)
+		logConfig(frameContext, *config, *strengthConfig);
 }
 
 REGISTER_IPA_ALGORITHM(Dpf, "Dpf")
diff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h
index df9d5746..dcd14dc6 100644
--- a/src/ipa/rkisp1/algorithms/dpf.h
+++ b/src/ipa/rkisp1/algorithms/dpf.h
@@ -42,9 +42,13 @@  private:
 			      rkisp1_cif_isp_dpf_strength_config &strengthConfig);
 
 	bool loadConfig(int32_t mode);
+	void logConfig(const IPAFrameContext &frameContext,
+		       const struct rkisp1_cif_isp_dpf_config &config,
+		       const struct rkisp1_cif_isp_dpf_strength_config &strengthConfig) const;
 
 	void prepareDisabledMode(RkISP1Params *params);
-	void prepareEnabledMode(IPAContext &context, RkISP1Params *params);
+	void prepareEnabledMode(IPAContext &context, IPAFrameContext &frameContext,
+				RkISP1Params *params);
 
 	std::vector<ModeConfig> noiseReductionModes_;
 	std::vector<ModeConfig>::const_iterator activeMode_;