[v11,22/24] libcamera: software_isp: Switch on default CCM at 65k
diff mbox series

Message ID 20260106170059.56193-23-bryan.odonoghue@linaro.org
State Accepted
Commit a350ad5467d355fa16ad5594017f1f33aa5dfb11
Headers show
Series
  • Add GLES 2.0 GPUISP to libcamera
Related show

Commit Message

Bryan O'Donoghue Jan. 6, 2026, 5 p.m. UTC 
Switch on the uncalibrated CCM @ 65k colour temperature. This will become
the default for SoftISP where we have swtiched to GPUISP as default.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 src/ipa/simple/data/uncalibrated.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Milan Zamazal Jan. 6, 2026, 8:35 p.m. UTC | #1 
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:

> Switch on the uncalibrated CCM @ 65k colour temperature. This will become
> the default for SoftISP where we have swtiched to GPUISP as default.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

From v10:

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>

> ---
>  src/ipa/simple/data/uncalibrated.yaml | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml
> index 5508e6686..8b6df9afc 100644
> --- a/src/ipa/simple/data/uncalibrated.yaml
> +++ b/src/ipa/simple/data/uncalibrated.yaml
> @@ -8,12 +8,12 @@ algorithms:
>    # Color correction matrices can be defined here. The CCM algorithm
>    # has a significant performance impact, and should only be enabled
>    # if tuned.
> -  # - Ccm:
> -  #     ccms:
> -  #       - ct: 6500
> -  #         ccm: [ 1, 0, 0,
> -  #                0, 1, 0,
> -  #                0, 0, 1]
> +  - Ccm:
> +      ccms:
> +        - ct: 6500
> +          ccm: [ 1, 0, 0,
> +                 0, 1, 0,
> +                 0, 0, 1]
>    - Lut:
>    - Agc:
>  ...

Patch
diff mbox series 

diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml
index 5508e6686..8b6df9afc 100644
--- a/src/ipa/simple/data/uncalibrated.yaml
+++ b/src/ipa/simple/data/uncalibrated.yaml
@@ -8,12 +8,12 @@  algorithms:
   # Color correction matrices can be defined here. The CCM algorithm
   # has a significant performance impact, and should only be enabled
   # if tuned.
-  # - Ccm:
-  #     ccms:
-  #       - ct: 6500
-  #         ccm: [ 1, 0, 0,
-  #                0, 1, 0,
-  #                0, 0, 1]
+  - Ccm:
+      ccms:
+        - ct: 6500
+          ccm: [ 1, 0, 0,
+                 0, 1, 0,
+                 0, 0, 1]
   - Lut:
   - Agc:
 ...