fix clang warnings/errors
diff mbox series

Message ID 20251227054042.3836430-1-johannes.schneider@leica-geosystems.com
State New
Headers show
Series
  • fix clang warnings/errors
Related show

Commit Message

Johannes Schneider Dec. 27, 2025, 5:40 a.m. UTC 
Building libcamera with clang raises some warnings-as-errors.

Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
---

Hoi,

you could/should consider compiling with clang too ;-)

gruß
Johannes

---
 include/libcamera/internal/camera_sensor_helper.h | 2 +-
 src/libcamera/converter/converter_v4l2_m2m.cpp    | 2 +-
 src/libcamera/pipeline/rkisp1/rkisp1.cpp          | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)

--
2.43.0

Patch
diff mbox series 

diff --git a/include/libcamera/internal/camera_sensor_helper.h b/include/libcamera/internal/camera_sensor_helper.h
index 1e1e479..1b3217b 100644
--- a/include/libcamera/internal/camera_sensor_helper.h
+++ b/include/libcamera/internal/camera_sensor_helper.h
@@ -61,7 +61,7 @@  public:

 	static std::vector<CameraSensorHelperFactoryBase *> &factories();

-	const std::string &name() const { return name_; };
+	const std::string &name() const { return name_; }

 private:
 	LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase)
diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp
index d6b95fb..368320f 100644
--- a/src/libcamera/converter/converter_v4l2_m2m.cpp
+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp
@@ -258,7 +258,7 @@  int V4L2M2MConverter::V4L2M2MStream::applyControls(ControlList &ctrls,
 						   const V4L2Request *request)
 {
 	return m2m_->capture()->setControls(&ctrls, request);
-};
+}

 /* -----------------------------------------------------------------------------
  * V4L2M2MConverter
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
index ca9e850..1437318 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
@@ -377,7 +377,6 @@  int RkISP1CameraData::loadTuningFile(const std::string &path)
 			const auto &params = algo["Dewarp"];

 			canUseDewarper_ = true;
-			Matrix<double, 3, 3> m;
 			DewarpParms dp;
 			if (params["cm"]) {
 				const auto &cm = params["cm"].get<Matrix<double, 3, 3>>();