| Message ID | 20251210164055.17856-9-david.plowman@raspberrypi.com |
|---|---|
| State | New |
| Headers | show
Return-Path: <libcamera-devel-bounces@lists.libcamera.org> X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D69DFC32AF for <parsemail@patchwork.libcamera.org>; Wed, 10 Dec 2025 16:41:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BC016614B6; Wed, 10 Dec 2025 17:41:11 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="O6c3/Cks"; dkim-atps=neutral Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A96A86149B for <libcamera-devel@lists.libcamera.org>; Wed, 10 Dec 2025 17:41:05 +0100 (CET) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-477b1cc8fb4so49470485e9.1 for <libcamera-devel@lists.libcamera.org>; Wed, 10 Dec 2025 08:41:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1765384865; x=1765989665; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=agjDQf+CjyYZrdgafhj0qeb/BZpvrZ5zUAV15xS2+/M=; b=O6c3/CksFqloV4FNJ8UOXpxt1g4znewLGkT99JAwohWyZQQIcAtaXYjZV0gvQD8m/Q D4FWi9BCg4vnV3qxYg4neSgJZYLwcmgYhqKXmHPyksDhNbtaaxp5PP7EtMqWpOKYU3Py SylGEKGzvk/MW3IY4IhoaxjiOaVaiGcfBxi/1xNhBIMrFV8E+2vpCtDmOIHAeYY48mMn xAUW5D4xj+us5g76AxuCfilqmLC/9asr8x2xR8JG0elDQskjz6SpYayitF79/K0DfENG PlcvBlLe8fwkJs0DGlcVr7NKWInCGCg+YKoFV+6LXPAz9zp66XUC65NnSykho9jeQfO9 Qqhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765384865; x=1765989665; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=agjDQf+CjyYZrdgafhj0qeb/BZpvrZ5zUAV15xS2+/M=; b=GOPu/8fiJvgGVidDu8362Lco1MwSf6EX4AU1dqhblW6AL23DpnAZMvE9g8mZB6QaSj d4izsGGr+yZ5WkC6yxcgqamt00j7mvvSo/W9kfbTJ47U371cFwoeIxby+5wdPmvDntvs Bx4fGWMZPn/esHE9zV+9G1ToyWafHo/VLbTMwyCS8xPtMrg/us55H5kTdWK9//ngJ9Qo ZdjdBRUeUaJz2BAzSS5/0fN0rizGLwOMYExPQkohuI8qV1PGfunkxY4dBZt9Yueule2p CJfA2S67oCO509nIJ+pQq0yK5K77HpupFNSPqA0CFwEi9bZsIywRJ58ZM45/rN7M20Cd gYHA== X-Gm-Message-State: AOJu0Yz01Uc9NTnxFz8qtY7mv+xAPkBOTyfuIlG1+FWIo3c0t1b6oDHc DahZK39iqW7Po1PudwzRkhuUN7Zn69lAooMwFYZXRc1WTbTtnDMKafhm4SPbA4dLhFPz2mWX9NA bkb3r X-Gm-Gg: ASbGncv9+f9OJS6QHS8rq4Qe7vUMUH+sEUMyqKOlASvY4+axCd6A6YBTGQsI5uaxMGj 9cQU6whmYgjg70ri+OKEzMLLEFGbpafcIielPKTeR1zKqR14Q5UrxxwsnMCMPg+smjAqG04P+Dx tKts6H9sMAIrfSBIyI55vOPrBWRIrOPuITKEvC6fUxXefIoy0Bu1IWx1BpdmiSMlJ0h8/HR7PAn DG/bjEGj3obmi/69YTPrOEpficQFyjwIZnhNxzKhNr/FEArUuPvgZ5gU7JdUr4UPaFQ1REBC73j GH+cndLPuiAT94wovcOZtK7ZTAsxHNE4bjIAA0OVNa9OJWPKpqBgxkTJjZE9EMUaFjvXPrvqmOr zjZ0Zc3Nomnmv+6C03POQHRQDo04AIfoaDSic2Lnan+ss/8Bj/C9VDiSrBfvxs1IlaMBnwBArH9 fYD9aV6yRZZryB31/mgsxfQFuD/3TM5WvNuac6CmcBtcDTd+Gb21y/KQWvMelqaXXqvu9qQHKYh /0i3dYZynw4Od+meIdO/qa0mUbePA== X-Google-Smtp-Source: AGHT+IFdSRfIGBalCd1rdXJsa07qMN353a3ywIHtezOogRedeGao4EWdB0dV6aNQQyW6NJ3+kE0U3w== X-Received: by 2002:a05:600c:1c93:b0:471:d2f:7987 with SMTP id 5b1f17b1804b1-47a837b9a4cmr32309655e9.26.1765384864887; Wed, 10 Dec 2025 08:41:04 -0800 (PST) Received: from davidp-pi5.pitowers.org ([2a00:1098:3142:1f:88ea:c658:5b20:5e46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a88371e13sm1270415e9.11.2025.12.10.08.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 08:41:04 -0800 (PST) From: David Plowman <david.plowman@raspberrypi.com> To: libcamera-devel@lists.libcamera.org Cc: David Plowman <david.plowman@raspberrypi.com> Subject: [PATCH 08/11] libcamera: Don't wait for input streams to complete Date: Wed, 10 Dec 2025 16:15:23 +0000 Message-ID: <20251210164055.17856-9-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251210164055.17856-1-david.plowman@raspberrypi.com> References: <20251210164055.17856-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <libcamera-devel.lists.libcamera.org> List-Unsubscribe: <https://lists.libcamera.org/options/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe> List-Archive: <https://lists.libcamera.org/pipermail/libcamera-devel/> List-Post: <mailto:libcamera-devel@lists.libcamera.org> List-Help: <mailto:libcamera-devel-request@lists.libcamera.org?subject=help> List-Subscribe: <https://lists.libcamera.org/listinfo/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe> Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" <libcamera-devel-bounces@lists.libcamera.org> |
| Series |
|
| Related |
show
|
diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 60565f59..1be5e6e5 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -493,7 +493,9 @@ int Request::addBuffer(const Stream *stream, FrameBuffer *buffer, } buffer->_d()->setRequest(this); - _d()->pending_.insert(buffer); + /* Don't want to wait for input buffers as they don't "complete". */ + if (!stream->configuration().isInput()) + _d()->pending_.insert(buffer); if (fence && fence->isValid()) buffer->_d()->setFence(std::move(fence));
Don't add buffers corresponding to input streams to the "pending" list. These buffers don't "complete" in the normal way, which would stop a request from ever completing. Signed-off-by: David Plowman <david.plowman@raspberrypi.com> --- src/libcamera/request.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)