| Message ID | 20251210005354.44726-13-bryan.odonoghue@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes: > In order to have Debayer::start() tell the eGL shader compilation routine what > the input and output pixel format is, we need to have a copy of the > selected format available. Add variables to the inputConfig and > outputConfig structures to allow tracking of this data for later use. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > src/libcamera/software_isp/debayer.cpp | 10 ++++++++++ > src/libcamera/software_isp/debayer.h | 2 ++ > 2 files changed, 12 insertions(+) > > diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp > index 63a61daf9..ebd3e3a8b 100644 > --- a/src/libcamera/software_isp/debayer.cpp > +++ b/src/libcamera/software_isp/debayer.cpp > @@ -290,6 +290,16 @@ Debayer::~Debayer() > * output image buffer. Set during stream configuration. > */ > > +/** > + * \var Debayer::inputPixelFormat_ > + * \brief The incoming pixel format. No end of line dot in \brief. The same below. Reviewed-by: Milan Zamazal <mzamazal@redhat.com> > + */ > + > +/** > + * \var Debayer::outputPixelFormat_ > + * \brief The output pixel format. > + */ > + > /** > * \var Debayer::red_ > * \brief Lookup table for red channel gain and correction values. > diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h > index 5c0cb3914..4a2ec3e53 100644 > --- a/src/libcamera/software_isp/debayer.h > +++ b/src/libcamera/software_isp/debayer.h > @@ -75,6 +75,8 @@ public: > > DebayerInputConfig inputConfig_; > DebayerOutputConfig outputConfig_; > + PixelFormat inputPixelFormat_; > + PixelFormat outputPixelFormat_; > DebayerParams::LookupTable red_; > DebayerParams::LookupTable green_; > DebayerParams::LookupTable blue_;
diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp index 63a61daf9..ebd3e3a8b 100644 --- a/src/libcamera/software_isp/debayer.cpp +++ b/src/libcamera/software_isp/debayer.cpp @@ -290,6 +290,16 @@ Debayer::~Debayer() * output image buffer. Set during stream configuration. */ +/** + * \var Debayer::inputPixelFormat_ + * \brief The incoming pixel format. + */ + +/** + * \var Debayer::outputPixelFormat_ + * \brief The output pixel format. + */ + /** * \var Debayer::red_ * \brief Lookup table for red channel gain and correction values. diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h index 5c0cb3914..4a2ec3e53 100644 --- a/src/libcamera/software_isp/debayer.h +++ b/src/libcamera/software_isp/debayer.h @@ -75,6 +75,8 @@ public: DebayerInputConfig inputConfig_; DebayerOutputConfig outputConfig_; + PixelFormat inputPixelFormat_; + PixelFormat outputPixelFormat_; DebayerParams::LookupTable red_; DebayerParams::LookupTable green_; DebayerParams::LookupTable blue_;
In order to have Debayer::start() tell the eGL shader compilation routine what the input and output pixel format is, we need to have a copy of the selected format available. Add variables to the inputConfig and outputConfig structures to allow tracking of this data for later use. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- src/libcamera/software_isp/debayer.cpp | 10 ++++++++++ src/libcamera/software_isp/debayer.h | 2 ++ 2 files changed, 12 insertions(+)