libcamera: simple: Move colour space logging after adjustment
diff mbox series

Message ID 20251204164634.82839-1-mzamazal@redhat.com
State Accepted
Commit 0a9cf7e0eb6aafcfaeda4c5774fb04db9186430d
Headers show
Series
  • libcamera: simple: Move colour space logging after adjustment
Related show

Commit Message

Milan Zamazal Dec. 4, 2025, 4:46 p.m. UTC 
The log message about adjusting an unspecified colour space should log
the value after, not before, the adjustment.

Fixes: 5a33bc10e9d3bc ("libcamera: software_isp: Assign colour spaces in configurations")
Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Umang Jain <uajain@igalia.com>
Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
---
 src/libcamera/pipeline/simple/simple.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
index a06a52926..ebbb04fb2 100644
--- a/src/libcamera/pipeline/simple/simple.cpp
+++ b/src/libcamera/pipeline/simple/simple.cpp
@@ -1249,9 +1249,6 @@  CameraConfiguration::Status SimpleCameraConfiguration::validate()
 			default:
 				cfg.colorSpace = ColorSpace::Raw;
 			}
-			LOG(SimplePipeline, Debug)
-				<< "Unspecified color space set to "
-				<< cfg.colorSpace.value().toString();
 			/*
 			 * Adjust the assigned color space to make sure everything is OK.
 			 * Since this is assigning an unspecified color space rather than
@@ -1259,6 +1256,9 @@  CameraConfiguration::Status SimpleCameraConfiguration::validate()
 			 * to Adjusted.
 			 */
 			cfg.colorSpace->adjust(pixelFormat);
+			LOG(SimplePipeline, Debug)
+				<< "Unspecified color space set to "
+				<< cfg.colorSpace.value().toString();
 		} else {
 			if (cfg.colorSpace->adjust(pixelFormat)) {
 				LOG(SimplePipeline, Debug)