| Message ID | 20251130012138.2755931-1-rui.wang@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
diff --git a/src/ipa/rkisp1/algorithms/filter.cpp b/src/ipa/rkisp1/algorithms/filter.cpp index 8ad79801..dfa2b65a 100644 --- a/src/ipa/rkisp1/algorithms/filter.cpp +++ b/src/ipa/rkisp1/algorithms/filter.cpp @@ -37,7 +37,7 @@ namespace ipa::rkisp1::algorithms { LOG_DEFINE_CATEGORY(RkISP1Filter) static constexpr uint32_t kFiltLumWeightDefault = 0x00022040; -static constexpr uint32_t kFiltModeDefault = 0x000004f2; +static constexpr uint32_t kFiltModeDefault = 0x000004f3; /** * \copydoc libcamera::ipa::Algorithm::init
The filter mode register was not configured correctly during mode changes. When sharpness is enabled, the driver also enables the DNR mode, but the default mode value (0x4f2) has bit 0 cleared, which disables the filter module entirely. As a result, neither sharpness nor DNR are actually enabled after a NoiseReductionMode transition such as OFF → FAST. Additionally, the filter block is not retriggered when switching states. Signed-off-by: Rui Wang <rui.wang@ideasonboard.com> --- changelog : delete bit set for sharpness control from prepare() --- src/ipa/rkisp1/algorithms/filter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)