[v3,13/29] libcamera: rkisp1: Allow upscaling when the dewarper is present
diff mbox series

Message ID 20251125162851.2301793-14-stefan.klug@ideasonboard.com
State Accepted
Headers show
Series
  • Full dewarper support on imx8mp
Related show

Commit Message

Stefan Klug Nov. 25, 2025, 4:28 p.m. UTC 
When the dewarper is present, there is no need to forbid upscaling of
the image data.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

---

Changes in v3:
- Collected tag
---
 src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Kieran Bingham Nov. 25, 2025, 5:08 p.m. UTC | #1 
Quoting Stefan Klug (2025-11-25 16:28:25)
> When the dewarper is present, there is no need to forbid upscaling of
> the image data.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> 
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
> 
> Changes in v3:
> - Collected tag
> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 2d89b0b41958..79c8717c839a 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -609,6 +609,11 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()
>                         return false;
>  
>                 if (useDewarper) {
> +                       /*
> +                        * The dewarper output is independent of the ISP path.
> +                        * Reset to the originally requested size.
> +                        */
> +                       tryCfg.size = cfg.size;
>                         bool adjusted;
>  
>                         pipe->dewarper_->validateOutput(&tryCfg, &adjusted,
> -- 
> 2.51.0
>

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
index 2d89b0b41958..79c8717c839a 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
@@ -609,6 +609,11 @@  CameraConfiguration::Status RkISP1CameraConfiguration::validate()
 			return false;
 
 		if (useDewarper) {
+			/*
+			 * The dewarper output is independent of the ISP path.
+			 * Reset to the originally requested size.
+			 */
+			tryCfg.size = cfg.size;
 			bool adjusted;
 
 			pipe->dewarper_->validateOutput(&tryCfg, &adjusted,