| Message ID | 20251122205507.37387-4-johannes.goede@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show
Return-Path: <libcamera-devel-bounces@lists.libcamera.org> X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1C0E5C3334 for <parsemail@patchwork.libcamera.org>; Sat, 22 Nov 2025 20:55:21 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A0F4C60AA1; Sat, 22 Nov 2025 21:55:20 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="SeyNm/Wu"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Hil755mH"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 033FE606E6 for <libcamera-devel@lists.libcamera.org>; Sat, 22 Nov 2025 21:55:17 +0100 (CET) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AMKPmnl3626695 for <libcamera-devel@lists.libcamera.org>; Sat, 22 Nov 2025 20:55:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=5sMGVwnGbnv PIoikCtB+aUp3FLBN0seGy74Gac56oBQ=; b=SeyNm/Wuq3Q2kPuAgDWFgOjMTZC 6AjOD6ouqH+g7d7cMADlnyo2u5BG5y4M8VgNjE7sX45XnQdvd8GIu83bkShEpvda e7TQ+27eOJX2kHcBSN72yAaRhJlGuyRBSw6vnawG4aXsEK+xpofnAI/d+wF6S6L3 61BzSbGpAI/Ww3ZM1DAaCFFX1uTpX0thKX+GOq29pQJVivBzxDZB0kKOLGNtkdec dro48somJbB7HIwf1bBQcjUQTgY4Uu3AIQfdAMkKN0FqBIxlD3A2YHfyNkfytxl3 56IJzhj6+uEq0CVgqc0K/+v0a0KL8HLypKAd30Cv/LMQCa/WPNabUzeiHEg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ak6cds9bg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for <libcamera-devel@lists.libcamera.org>; Sat, 22 Nov 2025 20:55:16 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ee42d99125so88289041cf.3 for <libcamera-devel@lists.libcamera.org>; Sat, 22 Nov 2025 12:55:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763844916; x=1764449716; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5sMGVwnGbnvPIoikCtB+aUp3FLBN0seGy74Gac56oBQ=; b=Hil755mHPyzK68zLArFlP3olyyjLfHvLk+oL8qyS3r0HtwB3ouMoVr6LGaWpiND2Yv vz9s4N+jIYEi9i0ASmbgwMZ8FYDxeM8+Ak2aO07Txj0KPkGc90CuMi21d1Q5UH1XyokD 0lUTGp8+XR+xc8pVpA7GILKw1knhkVhHJyntGhbO5hQswEdEsPV/52RU8AIRnp5tXlay D6zCQLIfwlAa9tYpGRmJfKk9j/YRPcxPkI2bxmJyIVJWvLj1YbASrNpxmgeumB2ljIkA 2JvwlZQktVpCTOGZMUmjG6Jtg+9bpcT040Ct9aos4kIh3uDccJplHtTDSo9vCgcpc6Rt GBbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763844916; x=1764449716; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5sMGVwnGbnvPIoikCtB+aUp3FLBN0seGy74Gac56oBQ=; b=PtaW4ciFyPd5Wvyi00SS3HNDZ71Ie+tGZh0qTlS3YYTfJuRPhQLNiBw5aAsZ2KxWaM SXczH9BOV8Qq64YVS/N3J9/8+RfQskCMYKUZiRznuil9xYyTEs4cWXgQ7vtHKAvmVcve gtyyafotMPezjgKGbTIYJ+2MDtnj26+4KhE7h7KvUhYyiQO0z9srpwepI0ZdQvgCIQJr tSx48vbqc7uc6NhPgVw57ubTWxk0iDLFvkaLp03Y3DafFMQCoghYu3TREZdLzi+zo9+J innJrXLk9fymD+CXdoLBB0lyXmrZHIIhWZvWkeR9VtKm3yoZWciFgqfLmT0Dm9TRpIWE VXfQ== X-Gm-Message-State: AOJu0YxI9iAxnluSqCGPJWRO6fJUMSXEmah9aOnlBgjVZCFIuf2J21p5 sFs81gZ3arWxvmprkVTb3cS6rzWeB2H3adAPbCtoN/F8HujAGHLLacqTm77hSvw/2mLVw9oh+dh 0Hk1kwD6dbXPoqDy/TU4oLUBC63eNf3Cs0DgJrLxqRReX0/5dwpk855k9pdZ9+DDG054yr/ryw0 ofzKDTKwhx X-Gm-Gg: ASbGncuxjfN62/2/YDhot3IoBGJfYlvethKVdrttZd664oQJapm/T5NOzoUMb/j0Scv f/sowVZF3huwNbVgJymi8/Hfq5XGuzN9J6y0z9sVXeWYbsjKpO7PbTHv1OloCCmkxrNIEdrwT/X xh7dTv4a/zL7/jgodN4dvaiXGnLfh1tJA63praQ1kcGO8rHQSHhfyXRdrcwgO7glt2VOHWOEC1B GQfHd+K4kh+VsPpOXyXc3cIgm/Nh1+CPPA9WFL3XV7mZofUfHy26jzy6Ved+h2vQkIhp+arD0Tr SUmR2PF+vWQPiLdOUG+PVbSxiMVYfK1GEjhDw/Xm8CsI/QY7dSzrBZeg59k2Q9BcfN17g/z/e2Z 1y3lUr9LwPZO8lmim5E4G1yfhMZeWbjy2dpde7TJwW91qmUAbjoyjG+rxdVOnQYr79j0MLO5Eic 7j55eocZ0Lx3F3zxf2y9iBlZ2Z X-Received: by 2002:a05:622a:1207:b0:4ee:1563:2829 with SMTP id d75a77b69052e-4ee58b04a99mr101402161cf.72.1763844916020; Sat, 22 Nov 2025 12:55:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IEVSOAD8w9X872h4azfrf5ZRjN32WQKK/R5ogJH8W0J82nJMRH3Qa61CdAFv3Fyr8ssAgDLdw== X-Received: by 2002:a05:622a:1207:b0:4ee:1563:2829 with SMTP id d75a77b69052e-4ee58b04a99mr101401761cf.72.1763844915343; Sat, 22 Nov 2025 12:55:15 -0800 (PST) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7655050c53sm822745966b.68.2025.11.22.12.55.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Nov 2025 12:55:14 -0800 (PST) From: Hans de Goede <johannes.goede@oss.qualcomm.com> To: libcamera-devel@lists.libcamera.org, Bryan O'Donoghue <bryan.odonoghue@linaro.org> Cc: Hans de Goede <johannes.goede@oss.qualcomm.com> Subject: [PATCH 3/3] libcamera: egl: Fix eGLImage() constructor stride calculation Date: Sat, 22 Nov 2025 21:55:07 +0100 Message-ID: <20251122205507.37387-4-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251122205507.37387-1-johannes.goede@oss.qualcomm.com> References: <20251122205507.37387-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=bsdBxUai c=1 sm=1 tr=0 ts=69222334 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=nKa267-EdcKCvconACgA:9 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: oDnFUWblp7zHi6QdXp8Q8kmPiDjZ8peW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIyMDE3NCBTYWx0ZWRfX37Jw0aVs7yOr ZiOP6qf4oBba1akx07DRc6BDszdNJNVIjazI1OZ6aw5gitV0wlzcer/4WYfc2wazUZHvqGVX4Zw wTQ0ZnlDqAfBKe2aQc980wDg9XVbfF97SA77hmhEwrK/L9U+aHt1ya4phbenMXKUWOgWOwxS/l3 y4wj8+N/oKO1NEV42hjXGCzl8NLlw6BaaKsc7f4EPtDHG4yLgd0aMS4N4Aw1ip3XCFy5mUkqD7I 6wD02vKVdLCEtKTr4JkV6rW+k/wAlH3iVtc0aShSzpfC3o+bhBWn2XKXLpK9yWZxe0WVc56k3mD 9JOU6l7RTga55oJF2LpHY6f95iZXjmgOGPmGE27TRmCyc+dICVc/COKfG1ZfhtMmXzdt1p1DmAR WMwcpTMPO56ft34t8PnmaCGxGd6++g== X-Proofpoint-GUID: oDnFUWblp7zHi6QdXp8Q8kmPiDjZ8peW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.9, FMLib:17.12.100.49 definitions=2025-11-22_08,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 clxscore=1015 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511220174 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <libcamera-devel.lists.libcamera.org> List-Unsubscribe: <https://lists.libcamera.org/options/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe> List-Archive: <https://lists.libcamera.org/pipermail/libcamera-devel/> List-Post: <mailto:libcamera-devel@lists.libcamera.org> List-Help: <mailto:libcamera-devel-request@lists.libcamera.org?subject=help> List-Subscribe: <https://lists.libcamera.org/listinfo/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe> Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" <libcamera-devel-bounces@lists.libcamera.org> |
| Series |
|
| Related |
show
|
diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h index e61a394a..5b7cb248 100644 --- a/include/libcamera/internal/egl.h +++ b/include/libcamera/internal/egl.h @@ -75,7 +75,7 @@ public: */ eGLImage(uint32_t width, uint32_t height, uint32_t bpp, GLenum texture_unit, uint32_t texture_unit_uniform_id) { - uint32_t stride = libcamera::utils::alignUp(width * bpp, 256); + uint32_t stride = libcamera::utils::alignUp(width * bpp / 8, 256); init(width, height, bpp, stride, texture_unit, texture_unit_uniform_id); }
The mimimum stride is width * bpp / 8 not width * bpp. Correct this to fix setting the stride to a value which is 8 times too large. Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com> --- This can be squashed into "libcamera: software_isp: egl: Add a eGL base helper class" --- include/libcamera/internal/egl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)