[v3,3/4] gstreamer: Improve logging for buffer pool activation
diff mbox series

Message ID 20251025142300.64480-4-uajain@igalia.com
State Superseded
Headers show
Series
  • gstreamer: Assorted fixes
Related show

Commit Message

Umang Jain Oct. 25, 2025, 2:22 p.m. UTC 
If the negotiation is going to fail, log the GST_ELEMENT_ERROR in
gst_libcamera_src_negotiate(), instead of logging in downstream method
chain.

Signed-off-by: Umang Jain <uajain@igalia.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/gstreamer/gstlibcamerasrc.cpp | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Comments

Nicolas Dufresne Oct. 28, 2025, 4:14 p.m. UTC | #1 
Hi,

Le samedi 25 octobre 2025 à 15:22 +0100, Umang Jain a écrit :
> If the negotiation is going to fail, log the GST_ELEMENT_ERROR in
> gst_libcamera_src_negotiate(), instead of logging in downstream method
> chain.
> 
> Signed-off-by: Umang Jain <uajain@igalia.com>
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
>  src/gstreamer/gstlibcamerasrc.cpp | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/src/gstreamer/gstlibcamerasrc.cpp
> b/src/gstreamer/gstlibcamerasrc.cpp
> index a3c48b1d..7bf42be2 100644
> --- a/src/gstreamer/gstlibcamerasrc.cpp
> +++ b/src/gstreamer/gstlibcamerasrc.cpp
> @@ -575,9 +575,7 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self,
> GstPad *srcpad,
>  	}
>  
>  	if (!gst_buffer_pool_set_active(pool, true)) {
> -		GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,
> -				  ("Failed to active buffer pool"),
> -				  ("gst_libcamera_src_negotiate() failed."));
> +		GST_ERROR_OBJECT(self, "Failed to activate buffer pool.");

This is redundant now, drop.

Nicolas

>  		return { nullptr, -EINVAL };
>  	}
>  
> @@ -680,8 +678,12 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)
>  			std::tie(video_pool, ret) =
>  				gst_libcamera_create_video_pool(self, srcpad,
>  								caps, &info);
> -			if (ret)
> +			if (ret) {
> +				GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,
> +						  ("Failed to create video
> pool: %s", g_strerror(-ret)),
> +						 
> ("gst_libcamera_src_negotiate() failed."));
>  				return false;
> +			}
>  		}
>  
>  		GstLibcameraPool *pool = gst_libcamera_pool_new(self-
> >allocator,

Patch
diff mbox series 

diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp
index a3c48b1d..7bf42be2 100644
--- a/src/gstreamer/gstlibcamerasrc.cpp
+++ b/src/gstreamer/gstlibcamerasrc.cpp
@@ -575,9 +575,7 @@  gst_libcamera_create_video_pool(GstLibcameraSrc *self, GstPad *srcpad,
 	}
 
 	if (!gst_buffer_pool_set_active(pool, true)) {
-		GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,
-				  ("Failed to active buffer pool"),
-				  ("gst_libcamera_src_negotiate() failed."));
+		GST_ERROR_OBJECT(self, "Failed to activate buffer pool.");
 		return { nullptr, -EINVAL };
 	}
 
@@ -680,8 +678,12 @@  gst_libcamera_src_negotiate(GstLibcameraSrc *self)
 			std::tie(video_pool, ret) =
 				gst_libcamera_create_video_pool(self, srcpad,
 								caps, &info);
-			if (ret)
+			if (ret) {
+				GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,
+						  ("Failed to create video pool: %s", g_strerror(-ret)),
+						  ("gst_libcamera_src_negotiate() failed."));
 				return false;
+			}
 		}
 
 		GstLibcameraPool *pool = gst_libcamera_pool_new(self->allocator,