| Message ID | 20251015012251.17508-29-bryan.odonoghue@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Bryan O'Donoghue (2025-10-15 02:22:40) > We get better sample resolution with highp instead of mediump. > Any other cost/impact on this ? I think I recall you said this fixed a lot of issues early on for you. Does it still make a big impact ? Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > include/libcamera/internal/shaders/RGB.frag | 2 +- > include/libcamera/internal/shaders/YUV_2_planes.frag | 2 +- > include/libcamera/internal/shaders/YUV_3_planes.frag | 2 +- > include/libcamera/internal/shaders/YUV_packed.frag | 2 +- > include/libcamera/internal/shaders/bayer_1x_packed.frag | 2 +- > include/libcamera/internal/shaders/bayer_unpacked.frag | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/libcamera/internal/shaders/RGB.frag b/include/libcamera/internal/shaders/RGB.frag > index 4c374ac9..72439589 100644 > --- a/include/libcamera/internal/shaders/RGB.frag > +++ b/include/libcamera/internal/shaders/RGB.frag > @@ -6,7 +6,7 @@ > */ > > #ifdef GL_ES > -precision mediump float; > +precision highp float; > #endif > > varying vec2 textureOut; > diff --git a/include/libcamera/internal/shaders/YUV_2_planes.frag b/include/libcamera/internal/shaders/YUV_2_planes.frag > index 1d5d1206..d286f117 100644 > --- a/include/libcamera/internal/shaders/YUV_2_planes.frag > +++ b/include/libcamera/internal/shaders/YUV_2_planes.frag > @@ -6,7 +6,7 @@ > */ > > #ifdef GL_ES > -precision mediump float; > +precision highp float; > #endif > > varying vec2 textureOut; > diff --git a/include/libcamera/internal/shaders/YUV_3_planes.frag b/include/libcamera/internal/shaders/YUV_3_planes.frag > index 8f788e90..8e3e0b4a 100644 > --- a/include/libcamera/internal/shaders/YUV_3_planes.frag > +++ b/include/libcamera/internal/shaders/YUV_3_planes.frag > @@ -6,7 +6,7 @@ > */ > > #ifdef GL_ES > -precision mediump float; > +precision highp float; > #endif > > varying vec2 textureOut; > diff --git a/include/libcamera/internal/shaders/YUV_packed.frag b/include/libcamera/internal/shaders/YUV_packed.frag > index b9ef9d41..3c9e3e39 100644 > --- a/include/libcamera/internal/shaders/YUV_packed.frag > +++ b/include/libcamera/internal/shaders/YUV_packed.frag > @@ -6,7 +6,7 @@ > */ > > #ifdef GL_ES > -precision mediump float; > +precision highp float; > #endif > > varying vec2 textureOut; > diff --git a/include/libcamera/internal/shaders/bayer_1x_packed.frag b/include/libcamera/internal/shaders/bayer_1x_packed.frag > index f53f5575..19b13ad0 100644 > --- a/include/libcamera/internal/shaders/bayer_1x_packed.frag > +++ b/include/libcamera/internal/shaders/bayer_1x_packed.frag > @@ -20,7 +20,7 @@ > */ > > #ifdef GL_ES > -precision mediump float; > +precision highp float; > #endif > > /* > diff --git a/include/libcamera/internal/shaders/bayer_unpacked.frag b/include/libcamera/internal/shaders/bayer_unpacked.frag > index 7e35ca88..aa7a1b00 100644 > --- a/include/libcamera/internal/shaders/bayer_unpacked.frag > +++ b/include/libcamera/internal/shaders/bayer_unpacked.frag > @@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro > > //Pixel Shader > #ifdef GL_ES > -precision mediump float; > +precision highp float; > #endif > > /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/ > -- > 2.51.0 >
diff --git a/include/libcamera/internal/shaders/RGB.frag b/include/libcamera/internal/shaders/RGB.frag index 4c374ac9..72439589 100644 --- a/include/libcamera/internal/shaders/RGB.frag +++ b/include/libcamera/internal/shaders/RGB.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/include/libcamera/internal/shaders/YUV_2_planes.frag b/include/libcamera/internal/shaders/YUV_2_planes.frag index 1d5d1206..d286f117 100644 --- a/include/libcamera/internal/shaders/YUV_2_planes.frag +++ b/include/libcamera/internal/shaders/YUV_2_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/include/libcamera/internal/shaders/YUV_3_planes.frag b/include/libcamera/internal/shaders/YUV_3_planes.frag index 8f788e90..8e3e0b4a 100644 --- a/include/libcamera/internal/shaders/YUV_3_planes.frag +++ b/include/libcamera/internal/shaders/YUV_3_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/include/libcamera/internal/shaders/YUV_packed.frag b/include/libcamera/internal/shaders/YUV_packed.frag index b9ef9d41..3c9e3e39 100644 --- a/include/libcamera/internal/shaders/YUV_packed.frag +++ b/include/libcamera/internal/shaders/YUV_packed.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/include/libcamera/internal/shaders/bayer_1x_packed.frag b/include/libcamera/internal/shaders/bayer_1x_packed.frag index f53f5575..19b13ad0 100644 --- a/include/libcamera/internal/shaders/bayer_1x_packed.frag +++ b/include/libcamera/internal/shaders/bayer_1x_packed.frag @@ -20,7 +20,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif /* diff --git a/include/libcamera/internal/shaders/bayer_unpacked.frag b/include/libcamera/internal/shaders/bayer_unpacked.frag index 7e35ca88..aa7a1b00 100644 --- a/include/libcamera/internal/shaders/bayer_unpacked.frag +++ b/include/libcamera/internal/shaders/bayer_unpacked.frag @@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro //Pixel Shader #ifdef GL_ES -precision mediump float; +precision highp float; #endif /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/
We get better sample resolution with highp instead of mediump. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- include/libcamera/internal/shaders/RGB.frag | 2 +- include/libcamera/internal/shaders/YUV_2_planes.frag | 2 +- include/libcamera/internal/shaders/YUV_3_planes.frag | 2 +- include/libcamera/internal/shaders/YUV_packed.frag | 2 +- include/libcamera/internal/shaders/bayer_1x_packed.frag | 2 +- include/libcamera/internal/shaders/bayer_unpacked.frag | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)