Message ID | 20251015012251.17508-14-bryan.odonoghue@linaro.org |
---|---|
State | New |
Headers | show
Return-Path: <libcamera-devel-bounces@lists.libcamera.org> X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7EB7BC3332 for <parsemail@patchwork.libcamera.org>; Wed, 15 Oct 2025 01:23:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 265CA60628; Wed, 15 Oct 2025 03:23:18 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ejfU1W1M"; dkim-atps=neutral Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A733960623 for <libcamera-devel@lists.libcamera.org>; Wed, 15 Oct 2025 03:23:08 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-b3ee18913c0so965014666b.3 for <libcamera-devel@lists.libcamera.org>; Tue, 14 Oct 2025 18:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760491388; x=1761096188; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X8BVCiPsJ20OX+RnXwnsSBdZMAPl34rKU86maQCSeW8=; b=ejfU1W1M/9pERQ11XOjaGMik5kYIUJBzDewTrM4h1noTNJbS+1RuyeTCj1kSZcr/9z 29GVpImqM6iMeUnzRrtow/05xhmBm70WFXDT54hmUvRf1QzQAYbW02rKg/2J+XHuwe+k T4mBNy9voTnjqs9j6/Y1y9PglVIs4OfjPDAogjMZNuzZXTyF18AJG00a6R0RDpZ4uc0L 1YiYqRy/Q4BBh+h1DdDbsWEDYT+jw6gWxGPKsnaefYfdqXNzbTg+P76rkviCZ/PomcvQ qvDDOER272UHI26jqjDKOo1W4bMelJC9tYWnu+2Wp2fPWZVWqlKynynGQmunoMbk0Dk6 zQ5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760491388; x=1761096188; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X8BVCiPsJ20OX+RnXwnsSBdZMAPl34rKU86maQCSeW8=; b=B36fP/hYT8U2uzulLkfwPiZPFWGWDnQ0+p00BvkIoDUbntwURV7QpWWcNIoAbS604+ 9Lw/Ksk/iQKxA2lmig8F6WvCKHSijxMWhFJAPntTmPtbiVtz8aKIoqt+fbpLqE1NvPcp YUaOuXw0wwDih2KlEhjfDi/PnE2iKWudxLiQ29wQqGRJxsxvJ2ua4uVrSqCsZO5Aq4e1 cJD4H2G1Y3NW49sxzArfjB3YO2ZlnAJBgL8ZaI47c/lJluOwD6rkKmtLkfDU3JAyZ8Vd E9s9zTEpew6f2vRV9zPHCu4xNNQoZMlHChUTpUvgFbamKwhW+Hvn9OB8UQgyJjV6BYwO BgpQ== X-Gm-Message-State: AOJu0Yx+DJnzx0XhdJ+F+5W4lSKAq5EP/B0K6eyJ4dLfyokXxzgqQmUL sG670Oc4dpvnBXIpOymVJqtvJESCfNGanCATASuZ9vej+njBJvXxGEVkoVN5QPil/z3nhKJ0gct J2VlE X-Gm-Gg: ASbGnctMg95wQM58LiEA9S0py9F6rpV8Kb7AAa2PnXPZyaIWkWo0haeib1bwOaKWU7y j7GsGKpZmGvb33gztmfkEgw+6Moso+YOsLllZNztS/X5yI+5AnlKJJgWVBNCHc+ybDlnYxj0J6l PeNdEJ24txsSGfxHhILqcQhtTJXG2CKe2qnxp1ty4MliyHVCDutAKPDsEXg1LQvnG85oslB5dfA vYznpP2lNikDBJ2RDMwuVjK3FQ6GOspryWdhzBe16xRX6f1S3OiHjB0tG40j6BHw2Dii+RSl5W+ SFinhTPuv63CaNMUSAcXcX2EvtSKiTRhXYNaDDcRDMFhP7ifzShATOoDecsFxz8Nt3YpXdGDW2P N/+DgBVBtrzNMm5gdjrPbLU/Xy2l9p4+DkZJlBxwdbuUpFhU0vXURhyLn8rFMd5Ty+jGfPeYn27 2o70FUmt9+R3NIkt9YLw4mO7IGfHUECnLstQG4+eDI X-Google-Smtp-Source: AGHT+IFwl/PRrmj32I33SAQDCfAv33qd36LXUt5m8+CiEiErR8C1iWDyb7pV6Ix70JVs1HGjr3D2GA== X-Received: by 2002:a17:907:7f8a:b0:b40:448d:cdb0 with SMTP id a640c23a62f3a-b50aba9f873mr2792191566b.41.1760491387938; Tue, 14 Oct 2025 18:23:07 -0700 (PDT) Received: from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.23.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 18:23:06 -0700 (PDT) From: Bryan O'Donoghue <bryan.odonoghue@linaro.org> To: libcamera-devel@lists.libcamera.org Cc: hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org, bod.linux@nxsw.ie, Robert Mader <robert.mader@collabora.com> Subject: [PATCH v3 13/39] libcamera: software_isp: Make output DMA sync contingent Date: Wed, 15 Oct 2025 02:22:25 +0100 Message-ID: <20251015012251.17508-14-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251015012251.17508-1-bryan.odonoghue@linaro.org> References: <20251015012251.17508-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <libcamera-devel.lists.libcamera.org> List-Unsubscribe: <https://lists.libcamera.org/options/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe> List-Archive: <https://lists.libcamera.org/pipermail/libcamera-devel/> List-Post: <mailto:libcamera-devel@lists.libcamera.org> List-Help: <mailto:libcamera-devel-request@lists.libcamera.org?subject=help> List-Subscribe: <https://lists.libcamera.org/listinfo/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe> Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" <libcamera-devel-bounces@lists.libcamera.org> |
Series |
|
Related |
show
|
diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp index 847067aa..96737c45 100644 --- a/src/libcamera/software_isp/debayer.cpp +++ b/src/libcamera/software_isp/debayer.cpp @@ -223,8 +223,10 @@ void Debayer::dmaSyncBegin(std::vector<DmaSyncer> &dmaSyncers, FrameBuffer *inpu for (const FrameBuffer::Plane &plane : input->planes()) dmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Read); - for (const FrameBuffer::Plane &plane : output->planes()) - dmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write); + if (output) { + for (const FrameBuffer::Plane &plane : output->planes()) + dmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write); + } } } /* namespace libcamera */
The DMA sync output buffer from the GPU need only have its cache invalidated if the CPU is going to modify the buffer. Right now this is not required for gpuisp so only act on the output buffer if it is non-null. Suggested-by: Robert Mader <robert.mader@collabora.com> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- src/libcamera/software_isp/debayer.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)