[v1,06/12] ipa: rkisp1: lsc: Rename res to samples
diff mbox series

Message ID 20251014075252.2876485-7-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • Add resampling support for polynomial LSC data
Related show

Commit Message

Stefan Klug Oct. 14, 2025, 7:52 a.m. UTC
Rename res to samples to better describe the intent. This was noted in
review after the series was merged.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 src/ipa/rkisp1/algorithms/lsc.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Barnabás Pőcze Oct. 14, 2025, 8:12 a.m. UTC | #1
2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta:
> Rename res to samples to better describe the intent. This was noted in
> review after the series was merged.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> ---

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   src/ipa/rkisp1/algorithms/lsc.cpp | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp
> index e4938dbd657c..e46943f4bae0 100644
> --- a/src/ipa/rkisp1/algorithms/lsc.cpp
> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp
> @@ -166,12 +166,12 @@ private:
>   		double y0 = cropRectangle_.y / m;
>   		double w = cropRectangle_.width / m;
>   		double h = cropRectangle_.height / m;
> -		std::vector<uint16_t> res;
> +		std::vector<uint16_t> samples;
>   
>   		ASSERT(xSizes_.size() * 2 + 1 == k);
>   		ASSERT(ySizes_.size() * 2 + 1 == k);
>   
> -		res.reserve(k * k);
> +		samples.reserve(k * k);
>   
>   		std::vector<double> xPos(sizesListToPositions(xSizes_));
>   		std::vector<double> yPos(sizesListToPositions(ySizes_));
> @@ -189,10 +189,10 @@ private:
>   					poly.sampleAtNormalizedPixelPos(xp, yp) *
>   					1024);
>   				v = std::min(std::max(v, 1024), 4095);
> -				res.push_back(v);
> +				samples.push_back(v);
>   			}
>   		}
> -		return res;
> +		return samples;
>   	}
>   
>   	Size sensorSize_;

Patch
diff mbox series

diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp
index e4938dbd657c..e46943f4bae0 100644
--- a/src/ipa/rkisp1/algorithms/lsc.cpp
+++ b/src/ipa/rkisp1/algorithms/lsc.cpp
@@ -166,12 +166,12 @@  private:
 		double y0 = cropRectangle_.y / m;
 		double w = cropRectangle_.width / m;
 		double h = cropRectangle_.height / m;
-		std::vector<uint16_t> res;
+		std::vector<uint16_t> samples;
 
 		ASSERT(xSizes_.size() * 2 + 1 == k);
 		ASSERT(ySizes_.size() * 2 + 1 == k);
 
-		res.reserve(k * k);
+		samples.reserve(k * k);
 
 		std::vector<double> xPos(sizesListToPositions(xSizes_));
 		std::vector<double> yPos(sizesListToPositions(ySizes_));
@@ -189,10 +189,10 @@  private:
 					poly.sampleAtNormalizedPixelPos(xp, yp) *
 					1024);
 				v = std::min(std::max(v, 1024), 4095);
-				res.push_back(v);
+				samples.push_back(v);
 			}
 		}
-		return res;
+		return samples;
 	}
 
 	Size sensorSize_;