| Message ID | 20251014075252.2876485-3-stefan.klug@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta: > The interpolateTable() function is not implemented anywhere. Drop the > declaration. > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> > --- It seems removed by you in a6adaa7283ce2ca22692a1d28b404a9ab15b59f0. Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > src/ipa/rkisp1/algorithms/lsc.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h > index 0e3745d5589c..7b68dda1a0d4 100644 > --- a/src/ipa/rkisp1/algorithms/lsc.h > +++ b/src/ipa/rkisp1/algorithms/lsc.h > @@ -39,9 +39,6 @@ public: > private: > void setParameters(rkisp1_cif_isp_lsc_config &config); > void copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0); > - void interpolateTable(rkisp1_cif_isp_lsc_config &config, > - const Components &set0, const Components &set1, > - const uint32_t ct); > > ipa::Interpolator<Components> sets_; > std::vector<double> xSize_;
Hi, Thank you for the review. Quoting Barnabás Pőcze (2025-10-14 10:12:51) > 2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta: > > The interpolateTable() function is not implemented anywhere. Drop the > > declaration. > > > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> > > --- > > It seems removed by you in a6adaa7283ce2ca22692a1d28b404a9ab15b59f0. I feared so :-) > > Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Thanks, Stefan > > > > src/ipa/rkisp1/algorithms/lsc.h | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h > > index 0e3745d5589c..7b68dda1a0d4 100644 > > --- a/src/ipa/rkisp1/algorithms/lsc.h > > +++ b/src/ipa/rkisp1/algorithms/lsc.h > > @@ -39,9 +39,6 @@ public: > > private: > > void setParameters(rkisp1_cif_isp_lsc_config &config); > > void copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0); > > - void interpolateTable(rkisp1_cif_isp_lsc_config &config, > > - const Components &set0, const Components &set1, > > - const uint32_t ct); > > > > ipa::Interpolator<Components> sets_; > > std::vector<double> xSize_; >
diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h index 0e3745d5589c..7b68dda1a0d4 100644 --- a/src/ipa/rkisp1/algorithms/lsc.h +++ b/src/ipa/rkisp1/algorithms/lsc.h @@ -39,9 +39,6 @@ public: private: void setParameters(rkisp1_cif_isp_lsc_config &config); void copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0); - void interpolateTable(rkisp1_cif_isp_lsc_config &config, - const Components &set0, const Components &set1, - const uint32_t ct); ipa::Interpolator<Components> sets_; std::vector<double> xSize_;
The interpolateTable() function is not implemented anywhere. Drop the declaration. Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> --- src/ipa/rkisp1/algorithms/lsc.h | 3 --- 1 file changed, 3 deletions(-)