Message ID | 20251013143342.174450-1-uajain@igalia.com |
---|---|
State | New |
Headers | show |
Series |
|
Related | show |
Le lundi 13 octobre 2025 à 20:03 +0530, Umang Jain a écrit : > Update the feature TODO list of libcamerasrc as it hasn't been > updated since its introduction. Following entries have been dropped > since they are supported: > > - Implement GstElement::request-new-pad (multi stream) > commit 53a0d80af0f9 ("gstreamer: Added virtual functions needed to support request pads") > > - Add framerate control > - Add framerate negotiation support > commit ccfe0a1af77c ("gstreamer: Provide framerate support for libcamerasrc") > > - Add colorimetry support > commit fc9783acc608 ("gstreamer: Provide colorimetry <> ColorSpace mappings") > > - Use unique names to select the camera devices > commit 2c93810ec1f1 ("gst: libcamerasrc: Add camera-name property") > (The property that is set here is fed into CameraManager::get() > eventually, ensuring we can select the camera devices by unique IDs.) > > At the same time, append the buffer importation support entry to > mention the potential usage of memory:DMAbuf, that landed in > gstreamer-1.26. > > Signed-off-by: Umang Jain <uajain@igalia.com> > --- > src/gstreamer/gstlibcamerasrc.cpp | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp > index 71236a0f..ac69ed15 100644 > --- a/src/gstreamer/gstlibcamerasrc.cpp > +++ b/src/gstreamer/gstlibcamerasrc.cpp > @@ -11,17 +11,12 @@ > * - Implement GstElement::send_event > * + Allowing application to use FLUSH/FLUSH_STOP > * + Prevent the main thread from accessing streaming thread > - * - Implement GstElement::request-new-pad (multi stream) > - * + Evaluate if a single streaming thread is fine > * - Add application driven request (snapshot) > - * - Add framerate control > * - Add buffer importation support > + * + Evaluate the feasibility of memory:DMAbuf support > * > * Requires new libcamera API: > - * - Add framerate negotiation support > - * - Add colorimetry support > * - Add timestamp support > - * - Use unique names to select the camera devices > * - Add GstVideoMeta support (strides and offsets) Can be updated too, see "848a3017 gstreamer: Add GstVideoMeta support". I think that todo was a bit ambiguous, since libcamera uses legacy method of single stride (single offset) and you have to guess the other strides, but for output it means we cover libcamera API entirely. The rest of the issues will fall into "importation support", since most importation will required more effort to verify that the stride[0] and offsets[1] and up matches the value libcamera will expect implicitly. Other then that: Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> Nicolas > */ >
diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index 71236a0f..ac69ed15 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -11,17 +11,12 @@ * - Implement GstElement::send_event * + Allowing application to use FLUSH/FLUSH_STOP * + Prevent the main thread from accessing streaming thread - * - Implement GstElement::request-new-pad (multi stream) - * + Evaluate if a single streaming thread is fine * - Add application driven request (snapshot) - * - Add framerate control * - Add buffer importation support + * + Evaluate the feasibility of memory:DMAbuf support * * Requires new libcamera API: - * - Add framerate negotiation support - * - Add colorimetry support * - Add timestamp support - * - Use unique names to select the camera devices * - Add GstVideoMeta support (strides and offsets) */
Update the feature TODO list of libcamerasrc as it hasn't been updated since its introduction. Following entries have been dropped since they are supported: - Implement GstElement::request-new-pad (multi stream) commit 53a0d80af0f9 ("gstreamer: Added virtual functions needed to support request pads") - Add framerate control - Add framerate negotiation support commit ccfe0a1af77c ("gstreamer: Provide framerate support for libcamerasrc") - Add colorimetry support commit fc9783acc608 ("gstreamer: Provide colorimetry <> ColorSpace mappings") - Use unique names to select the camera devices commit 2c93810ec1f1 ("gst: libcamerasrc: Add camera-name property") (The property that is set here is fed into CameraManager::get() eventually, ensuring we can select the camera devices by unique IDs.) At the same time, append the buffer importation support entry to mention the potential usage of memory:DMAbuf, that landed in gstreamer-1.26. Signed-off-by: Umang Jain <uajain@igalia.com> --- src/gstreamer/gstlibcamerasrc.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)