| Message ID | 20251010141826.42995-4-uajain@igalia.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi, Le vendredi 10 octobre 2025 à 19:48 +0530, Umang Jain a écrit : > If the negotiation is going to fail, log the GST_ELEMENT_ERROR in > gst_libcamera_src_negotiate(), instead of logging in downstream method > chain. > > Signed-off-by: Umang Jain <uajain@igalia.com> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> br, Nicolas > --- > src/gstreamer/gstlibcamerasrc.cpp | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/src/gstreamer/gstlibcamerasrc.cpp > b/src/gstreamer/gstlibcamerasrc.cpp > index a5dbdfd4..5a1b2676 100644 > --- a/src/gstreamer/gstlibcamerasrc.cpp > +++ b/src/gstreamer/gstlibcamerasrc.cpp > @@ -581,9 +581,7 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self, > GstPad *srcpad, > } > > if (!gst_buffer_pool_set_active(pool, true)) { > - GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS, > - ("Failed to active buffer pool"), > - ("gst_libcamera_src_negotiate() failed.")); > + GST_ERROR("Failed to activate buffer pool"); > return { nullptr, -EINVAL }; > } > > @@ -686,8 +684,12 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self) > std::tie(video_pool, ret) = > gst_libcamera_create_video_pool(self, srcpad, > caps, &info); > - if (ret) > + if (ret) { > + GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS, > + ("Failed to create video > pool: %s", g_strerror(-ret)), > + > ("gst_libcamera_src_negotiate() failed.")); > return false; > + } > } > > GstLibcameraPool *pool = gst_libcamera_pool_new(self- > >allocator,
diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index a5dbdfd4..5a1b2676 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -581,9 +581,7 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self, GstPad *srcpad, } if (!gst_buffer_pool_set_active(pool, true)) { - GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS, - ("Failed to active buffer pool"), - ("gst_libcamera_src_negotiate() failed.")); + GST_ERROR("Failed to activate buffer pool"); return { nullptr, -EINVAL }; } @@ -686,8 +684,12 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self) std::tie(video_pool, ret) = gst_libcamera_create_video_pool(self, srcpad, caps, &info); - if (ret) + if (ret) { + GST_ELEMENT_ERROR(self, RESOURCE, SETTINGS, + ("Failed to create video pool: %s", g_strerror(-ret)), + ("gst_libcamera_src_negotiate() failed.")); return false; + } } GstLibcameraPool *pool = gst_libcamera_pool_new(self->allocator,
If the negotiation is going to fail, log the GST_ELEMENT_ERROR in gst_libcamera_src_negotiate(), instead of logging in downstream method chain. Signed-off-by: Umang Jain <uajain@igalia.com> --- src/gstreamer/gstlibcamerasrc.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)