| Message ID | 20251010141826.42995-2-uajain@igalia.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi, Le vendredi 10 octobre 2025 à 19:48 +0530, Umang Jain a écrit : > Shorten the following utility function name: > gst_libcamera_stream_configuration_to_caps() > to > gst_libcamera_stream_cfg_to_caps() > > Comestic fix only for slight readability enhancement. As you can see, I'm not an acronym kind of person, but I guess if you made the effort to patch it, its because it bothers you enough :-D Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > > Signed-off-by: Umang Jain <uajain@igalia.com> > --- > src/gstreamer/gstlibcamera-utils.cpp | 4 ++-- > src/gstreamer/gstlibcamera-utils.h | 4 ++-- > src/gstreamer/gstlibcamerasrc.cpp | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp > index bfb094c9..09f274b5 100644 > --- a/src/gstreamer/gstlibcamera-utils.cpp > +++ b/src/gstreamer/gstlibcamera-utils.cpp > @@ -408,8 +408,8 @@ gst_libcamera_stream_formats_to_caps(const StreamFormats &formats) > } > > GstCaps * > -gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg, > - GstVideoTransferFunction transfer) > +gst_libcamera_stream_cfg_to_caps(const StreamConfiguration &stream_cfg, > + GstVideoTransferFunction transfer) > { > GstCaps *caps = gst_caps_new_empty(); > GstStructure *s = bare_structure_from_format(stream_cfg.pixelFormat); > diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h > index 35df56fb..06ea9289 100644 > --- a/src/gstreamer/gstlibcamera-utils.h > +++ b/src/gstreamer/gstlibcamera-utils.h > @@ -16,8 +16,8 @@ > #include <gst/video/video.h> > > GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &formats); > -GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfiguration &stream_cfg, > - GstVideoTransferFunction transfer); > +GstCaps *gst_libcamera_stream_cfg_to_caps(const libcamera::StreamConfiguration &stream_cfg, > + GstVideoTransferFunction transfer); > void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg, > GstCaps *caps, GstVideoTransferFunction *transfer); > void gst_libcamera_get_framerate_from_caps(GstCaps *caps, GstStructure *element_caps); > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp > index 79a025a5..9ff90d9a 100644 > --- a/src/gstreamer/gstlibcamerasrc.cpp > +++ b/src/gstreamer/gstlibcamerasrc.cpp > @@ -645,7 +645,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self) > GstPad *srcpad = state->srcpads_[i]; > const StreamConfiguration &stream_cfg = state->config_->at(i); > > - g_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]); > + g_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]); > gst_libcamera_framerate_to_caps(caps, element_caps); > > if (status == CameraConfiguration::Adjusted && > @@ -673,7 +673,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self) > GstBufferPool *video_pool = nullptr; > GstVideoInfo info; > > - g_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]); > + g_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]); > > gst_video_info_from_caps(&info, caps); > gst_libcamera_pad_set_video_info(srcpad, &info);
2025. 10. 10. 16:18 keltezéssel, Umang Jain írta: > Shorten the following utility function name: > gst_libcamera_stream_configuration_to_caps() > to > gst_libcamera_stream_cfg_to_caps() > > Comestic fix only for slight readability enhancement. > > Signed-off-by: Umang Jain <uajain@igalia.com> > --- Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > src/gstreamer/gstlibcamera-utils.cpp | 4 ++-- > src/gstreamer/gstlibcamera-utils.h | 4 ++-- > src/gstreamer/gstlibcamerasrc.cpp | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp > index bfb094c9..09f274b5 100644 > --- a/src/gstreamer/gstlibcamera-utils.cpp > +++ b/src/gstreamer/gstlibcamera-utils.cpp > @@ -408,8 +408,8 @@ gst_libcamera_stream_formats_to_caps(const StreamFormats &formats) > } > > GstCaps * > -gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg, > - GstVideoTransferFunction transfer) > +gst_libcamera_stream_cfg_to_caps(const StreamConfiguration &stream_cfg, > + GstVideoTransferFunction transfer) > { > GstCaps *caps = gst_caps_new_empty(); > GstStructure *s = bare_structure_from_format(stream_cfg.pixelFormat); > diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h > index 35df56fb..06ea9289 100644 > --- a/src/gstreamer/gstlibcamera-utils.h > +++ b/src/gstreamer/gstlibcamera-utils.h > @@ -16,8 +16,8 @@ > #include <gst/video/video.h> > > GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &formats); > -GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfiguration &stream_cfg, > - GstVideoTransferFunction transfer); > +GstCaps *gst_libcamera_stream_cfg_to_caps(const libcamera::StreamConfiguration &stream_cfg, > + GstVideoTransferFunction transfer); > void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg, > GstCaps *caps, GstVideoTransferFunction *transfer); > void gst_libcamera_get_framerate_from_caps(GstCaps *caps, GstStructure *element_caps); > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp > index 79a025a5..9ff90d9a 100644 > --- a/src/gstreamer/gstlibcamerasrc.cpp > +++ b/src/gstreamer/gstlibcamerasrc.cpp > @@ -645,7 +645,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self) > GstPad *srcpad = state->srcpads_[i]; > const StreamConfiguration &stream_cfg = state->config_->at(i); > > - g_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]); > + g_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]); > gst_libcamera_framerate_to_caps(caps, element_caps); > > if (status == CameraConfiguration::Adjusted && > @@ -673,7 +673,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self) > GstBufferPool *video_pool = nullptr; > GstVideoInfo info; > > - g_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]); > + g_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]); > > gst_video_info_from_caps(&info, caps); > gst_libcamera_pad_set_video_info(srcpad, &info);
diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp index bfb094c9..09f274b5 100644 --- a/src/gstreamer/gstlibcamera-utils.cpp +++ b/src/gstreamer/gstlibcamera-utils.cpp @@ -408,8 +408,8 @@ gst_libcamera_stream_formats_to_caps(const StreamFormats &formats) } GstCaps * -gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg, - GstVideoTransferFunction transfer) +gst_libcamera_stream_cfg_to_caps(const StreamConfiguration &stream_cfg, + GstVideoTransferFunction transfer) { GstCaps *caps = gst_caps_new_empty(); GstStructure *s = bare_structure_from_format(stream_cfg.pixelFormat); diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h index 35df56fb..06ea9289 100644 --- a/src/gstreamer/gstlibcamera-utils.h +++ b/src/gstreamer/gstlibcamera-utils.h @@ -16,8 +16,8 @@ #include <gst/video/video.h> GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &formats); -GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfiguration &stream_cfg, - GstVideoTransferFunction transfer); +GstCaps *gst_libcamera_stream_cfg_to_caps(const libcamera::StreamConfiguration &stream_cfg, + GstVideoTransferFunction transfer); void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg, GstCaps *caps, GstVideoTransferFunction *transfer); void gst_libcamera_get_framerate_from_caps(GstCaps *caps, GstStructure *element_caps); diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index 79a025a5..9ff90d9a 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -645,7 +645,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self) GstPad *srcpad = state->srcpads_[i]; const StreamConfiguration &stream_cfg = state->config_->at(i); - g_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]); + g_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]); gst_libcamera_framerate_to_caps(caps, element_caps); if (status == CameraConfiguration::Adjusted && @@ -673,7 +673,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self) GstBufferPool *video_pool = nullptr; GstVideoInfo info; - g_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]); + g_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]); gst_video_info_from_caps(&info, caps); gst_libcamera_pad_set_video_info(srcpad, &info);
Shorten the following utility function name: gst_libcamera_stream_configuration_to_caps() to gst_libcamera_stream_cfg_to_caps() Comestic fix only for slight readability enhancement. Signed-off-by: Umang Jain <uajain@igalia.com> --- src/gstreamer/gstlibcamera-utils.cpp | 4 ++-- src/gstreamer/gstlibcamera-utils.h | 4 ++-- src/gstreamer/gstlibcamerasrc.cpp | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-)