Message ID | 20250827090739.86955-10-david.plowman@raspberrypi.com |
---|---|
State | New |
Headers | show
Return-Path: <libcamera-devel-bounces@lists.libcamera.org> X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 49CF2C332C for <parsemail@patchwork.libcamera.org>; Wed, 27 Aug 2025 09:08:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B4C3E692FB; Wed, 27 Aug 2025 11:08:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Aj80iUXg"; dkim-atps=neutral Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 01D90692F9 for <libcamera-devel@lists.libcamera.org>; Wed, 27 Aug 2025 11:07:51 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-45b4e5c3d0fso15953315e9.2 for <libcamera-devel@lists.libcamera.org>; Wed, 27 Aug 2025 02:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1756285670; x=1756890470; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/8DD2bSs3QnQLjUdI5vBu7DuexdVhZjBW7O248brbbE=; b=Aj80iUXghkfdxygyRA61xJuCo/O7Ph6PfHM9ms57YMJrkUvo/JjiLLRobuMyzzkNiD ql+hgZ2LLujzufAfUZZOdl1fBKkbWVQ7vbklzPeogE7JANwv5TxsTO5i/r7ZdaWyiSbh 94eSfhQydxLLWP+dmQ5hn2vm/vHgLWHc+pa2AuTeXmuBFWYaSEu3vhoHUF52TzBNc1OD NWJvJoQwApL41Rm/KY2gMHbKi4xQr+wssuzhiWEqmeoZTZI1YVfQTQ7kOwee03xNv8lg x5XZwpH4uOHBpwEjRG08wB5SbFFB6OtI+a7d9KOKv3JNDJTa4oOsHpyIMeqx8zMUFJOr EIOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756285670; x=1756890470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/8DD2bSs3QnQLjUdI5vBu7DuexdVhZjBW7O248brbbE=; b=cJkAMs+SShcX0q0I1dYWMQ4D//5msNZXWvKrNRvx+x/J+rCGM6SBKBc3mBaCAAcv2K Jj4ayYKiX0F787v6+MScbMhKNyNbAfNNAN6wgazIQDxZivZcMgvR8WLfxxWK6lC1teJN 2ay4Y/9XowthFEvklOWjnuAt7wCwvEtQKfv1q8dQtezOzoTJUUedqogDs22/o/bMlLrT ZMXcodUXg1TSvBIt04auLjsyuj0KNupFT7LKps2RHOpKUEIM6csB2ohGdH4jGwFMUvQn D2W09V6Yvnc8FoZJ4QVau0RD9RSR0VkiuyN4pjoqx+DmZ5zWF4MkE23TX6+3CxAwAvnV wwcQ== X-Gm-Message-State: AOJu0Yz4tqNBLEKBGOIjghM0CdJvrRj1PryuIsh1B+Ob4GkqKqCRUaNH IL6aWPt6GZlJApZAHYsZtoz4jmYemvtVkUZBcWmMPPC7rWP6R6xef8c5mvKKB2FcsL/P/8660rD qU5L5 X-Gm-Gg: ASbGnct82n0DejXhkNuMzSsmHWXH979XAv0CLURrReOCyc2DAyBWECh31iPUdhGmSwP Hr4+W3jLgx9qtyIIotsL4gdk1MqEaje3QkOF1ZQlGcGku+YuhjN7jZ7U4kk7UqpyQRDAUBGwmEt JnqNX1g+ycfCEBEnDYPcsldnCSbbPkvG2nLn4iFTKQ4v8R9BeTe4iMbVYNaMW7XV7BYf3x99AGx 02e8bibqR4q6pbcS4c4Xfx7pqI3AKX2FZ639VLdOpiVwemW2wMZrPqIVK5S8FG5ap+sGA7j8orG Ylev9j1+Hb4KPyJvGdurS3bWOawnPaWf88YflLPY0b+z8myezaZ4GJjjkrOjkKOypJiJfWRTIzP EafNvhe3DoIRbRTNM2qM6C8jdQ3DtY6c45FyR3Dlgy1kV7fYNxG4wfeMblk9VlkmTFh/66LvXkT uWVdrcjBUPQnEro5JBl5QHSqn7fEkXWBWqYpTb4VY= X-Google-Smtp-Source: AGHT+IFGLMLtWpyI3x678rb7MLNBvH1tcYA3tf3Fqd+ysFpsR3zRnW8J7R3sBx3159DRC195IuYxng== X-Received: by 2002:a05:600c:3596:b0:458:bd31:2c35 with SMTP id 5b1f17b1804b1-45b517cca56mr171400475e9.25.1756285669923; Wed, 27 Aug 2025 02:07:49 -0700 (PDT) Received: from raspberrypi.pitowers.org ([2a00:1098:3142:1f:ffc9:aff6:7f7f:893b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b6f30fe02sm21498675e9.18.2025.08.27.02.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Aug 2025 02:07:49 -0700 (PDT) From: David Plowman <david.plowman@raspberrypi.com> To: libcamera-devel@lists.libcamera.org Cc: David Plowman <david.plowman@raspberrypi.com> Subject: [RFC PATCH 09/12] libcamera: Don't wait for input streams to complete Date: Wed, 27 Aug 2025 10:07:36 +0100 Message-Id: <20250827090739.86955-10-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250827090739.86955-1-david.plowman@raspberrypi.com> References: <20250827090739.86955-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <libcamera-devel.lists.libcamera.org> List-Unsubscribe: <https://lists.libcamera.org/options/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe> List-Archive: <https://lists.libcamera.org/pipermail/libcamera-devel/> List-Post: <mailto:libcamera-devel@lists.libcamera.org> List-Help: <mailto:libcamera-devel-request@lists.libcamera.org?subject=help> List-Subscribe: <https://lists.libcamera.org/listinfo/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe> Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" <libcamera-devel-bounces@lists.libcamera.org> |
Series |
|
Related |
show
|
diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 7f1e11e8..11de57d6 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -491,7 +491,9 @@ int Request::addBuffer(const Stream *stream, FrameBuffer *buffer, } buffer->_d()->setRequest(this); - _d()->pending_.insert(buffer); + /* Don't want to wait for input buffers as they don't "complete". */ + if (!stream->configuration().isInput()) + _d()->pending_.insert(buffer); if (fence && fence->isValid()) buffer->_d()->setFence(std::move(fence));
Don't add buffers corresponding to input streams to the "pending" list. These buffers don't "complete" in the normal way, which would stop a request from ever completing. Signed-off-by: David Plowman <david.plowman@raspberrypi.com> --- src/libcamera/request.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)