[v2,2/2] libcamera: sensor: imx462: Add sensor delays to CameraSensorProperties
diff mbox series

Message ID 20250827070656.286258-3-naush@raspberrypi.com
State New
Headers show
Series
  • RPi: IMX462 retune
Related show

Commit Message

Naushir Patuck Aug. 27, 2025, 7:03 a.m. UTC
The sensor delays for IMX462 were missing from the CameraSensorProperties
table. They are identical to the IMX290, so copy those values.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
---
 src/libcamera/sensor/camera_sensor_properties.cpp | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

David Plowman Aug. 27, 2025, 7:11 a.m. UTC | #1
Hi Naush

Thanks for this. I assume it fixes any "winking" problems...!

Reviewed-by: David Plowman <david.plowman@raspberrypi.com>

David

On Wed, 27 Aug 2025 at 08:07, Naushir Patuck <naush@raspberrypi.com> wrote:

> The sensor delays for IMX462 were missing from the CameraSensorProperties
> table. They are identical to the IMX290, so copy those values.
>
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> ---
>  src/libcamera/sensor/camera_sensor_properties.cpp | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp
> b/src/libcamera/sensor/camera_sensor_properties.cpp
> index f297341770d0..f2da8205372b 100644
> --- a/src/libcamera/sensor/camera_sensor_properties.cpp
> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp
> @@ -242,7 +242,12 @@ const CameraSensorProperties
> *CameraSensorProperties::get(const std::string &sen
>                 { "imx462", {
>                         .unitCellSize = { 2900, 2900 },
>                         .testPatternModes = {},
> -                       .sensorDelays = { },
> +                       .sensorDelays = {
> +                               .exposureDelay = 2,
> +                               .gainDelay = 2,
> +                               .vblankDelay = 2,
> +                               .hblankDelay = 2
> +                       },
>                 } },
>                 { "imx477", {
>                         .unitCellSize = { 1550, 1550 },
> --
> 2.43.0
>
>

Patch
diff mbox series

diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp
index f297341770d0..f2da8205372b 100644
--- a/src/libcamera/sensor/camera_sensor_properties.cpp
+++ b/src/libcamera/sensor/camera_sensor_properties.cpp
@@ -242,7 +242,12 @@  const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
 		{ "imx462", {
 			.unitCellSize = { 2900, 2900 },
 			.testPatternModes = {},
-			.sensorDelays = { },
+			.sensorDelays = {
+				.exposureDelay = 2,
+				.gainDelay = 2,
+				.vblankDelay = 2,
+				.hblankDelay = 2
+			},
 		} },
 		{ "imx477", {
 			.unitCellSize = { 1550, 1550 },