[6/6] ipa: rpi: sdn: Remove legacy denoise warning
diff mbox series

Message ID 20250822123709.16966-7-david.plowman@raspberrypi.com
State New
Headers show
Series
  • Camera tuning updates for Raspberry Pi
Related show

Commit Message

David Plowman Aug. 22, 2025, 12:37 p.m. UTC
We use the legacy format for the VC4 platform, and are not planning to
change this. So remove the warning.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
---
 src/ipa/rpi/controller/rpi/sdn.cpp | 2 --
 1 file changed, 2 deletions(-)

Comments

Naushir Patuck Aug. 26, 2025, 7:14 a.m. UTC | #1
Hi David,

On Fri, 22 Aug 2025 at 13:37, David Plowman
<david.plowman@raspberrypi.com> wrote:
>
> We use the legacy format for the VC4 platform, and are not planning to
> change this. So remove the warning.
>
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>

Reviewed-by: Naushir Patuck <naush@raspberrypi.com>

> ---
>  src/ipa/rpi/controller/rpi/sdn.cpp | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/ipa/rpi/controller/rpi/sdn.cpp b/src/ipa/rpi/controller/rpi/sdn.cpp
> index 619178a8..594ea701 100644
> --- a/src/ipa/rpi/controller/rpi/sdn.cpp
> +++ b/src/ipa/rpi/controller/rpi/sdn.cpp
> @@ -37,8 +37,6 @@ char const *Sdn::name() const
>
>  int Sdn::read(const libcamera::YamlObject &params)
>  {
> -       LOG(RPiSdn, Warning)
> -               << "Using legacy SDN tuning - please consider moving SDN inside rpi.denoise";
>         deviation_ = params["deviation"].get<double>(3.2);
>         strength_ = params["strength"].get<double>(0.75);
>         return 0;
> --
> 2.39.5
>

Patch
diff mbox series

diff --git a/src/ipa/rpi/controller/rpi/sdn.cpp b/src/ipa/rpi/controller/rpi/sdn.cpp
index 619178a8..594ea701 100644
--- a/src/ipa/rpi/controller/rpi/sdn.cpp
+++ b/src/ipa/rpi/controller/rpi/sdn.cpp
@@ -37,8 +37,6 @@  char const *Sdn::name() const
 
 int Sdn::read(const libcamera::YamlObject &params)
 {
-	LOG(RPiSdn, Warning)
-		<< "Using legacy SDN tuning - please consider moving SDN inside rpi.denoise";
 	deviation_ = params["deviation"].get<double>(3.2);
 	strength_ = params["strength"].get<double>(0.75);
 	return 0;