| Message ID | 20250815113400.20623-3-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
2025. 08. 15. 13:33 keltezéssel, Laurent Pinchart írta: > Multiple classes are forward-declared in frames.h, without being used in > that header file. Drop the unneeded forward declarations. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > src/libcamera/pipeline/ipu3/frames.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h > index 1cabd0e64d6e..36a23b9b198e 100644 > --- a/src/libcamera/pipeline/ipu3/frames.h > +++ b/src/libcamera/pipeline/ipu3/frames.h > @@ -19,11 +19,7 @@ > namespace libcamera { > > class FrameBuffer; > -class IPAProxy; > -class PipelineHandler; > class Request; > -class V4L2VideoDevice; > -struct IPABuffer; > > class IPU3Frames > {
Hi Laurent On Fri, Aug 15, 2025 at 02:33:54PM +0300, Laurent Pinchart wrote: > Multiple classes are forward-declared in frames.h, without being used in > that header file. Drop the unneeded forward declarations. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Indeed Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks j > --- > src/libcamera/pipeline/ipu3/frames.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h > index 1cabd0e64d6e..36a23b9b198e 100644 > --- a/src/libcamera/pipeline/ipu3/frames.h > +++ b/src/libcamera/pipeline/ipu3/frames.h > @@ -19,11 +19,7 @@ > namespace libcamera { > > class FrameBuffer; > -class IPAProxy; > -class PipelineHandler; > class Request; > -class V4L2VideoDevice; > -struct IPABuffer; > > class IPU3Frames > { > -- > Regards, > > Laurent Pinchart >
diff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h index 1cabd0e64d6e..36a23b9b198e 100644 --- a/src/libcamera/pipeline/ipu3/frames.h +++ b/src/libcamera/pipeline/ipu3/frames.h @@ -19,11 +19,7 @@ namespace libcamera { class FrameBuffer; -class IPAProxy; -class PipelineHandler; class Request; -class V4L2VideoDevice; -struct IPABuffer; class IPU3Frames {
Multiple classes are forward-declared in frames.h, without being used in that header file. Drop the unneeded forward declarations. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/libcamera/pipeline/ipu3/frames.h | 4 ---- 1 file changed, 4 deletions(-)