[v3,02/19] tuning: rksip1: Add a static Compress entry
diff mbox series

Message ID 20250815102945.1602071-3-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • Implement WDR algorithm
Related show

Commit Message

Stefan Klug Aug. 15, 2025, 10:29 a.m. UTC 
Add a static Compress entry that gets added by default.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

---

Changes in v3:
- Collected tags
---
 utils/tuning/rkisp1.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Paul Elder Sept. 5, 2025, 10:43 a.m. UTC | #1 
Quoting Stefan Klug (2025-08-15 19:29:22)
> Add a static Compress entry that gets added by default.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>
> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> 
> ---
> 
> Changes in v3:
> - Collected tags
> ---
>  utils/tuning/rkisp1.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py
> index 207b717a029c..179d920c05df 100755
> --- a/utils/tuning/rkisp1.py
> +++ b/utils/tuning/rkisp1.py
> @@ -27,6 +27,7 @@ awb = AWBRkISP1(debug=[lt.Debug.Plot])
>  blc = StaticModule('BlackLevelCorrection')
>  ccm = CCMRkISP1(debug=[lt.Debug.Plot])
>  color_processing = StaticModule('ColorProcessing')
> +compress = StaticModule('Compress')
>  filter = StaticModule('Filter')
>  gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2})
>  lsc = LSCRkISP1(debug=[lt.Debug.Plot],
> @@ -49,13 +50,14 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],
>  lux = LuxRkISP1(debug=[lt.Debug.Plot])
>  
>  tuner = lt.Tuner('RkISP1')
> -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux])
> +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, compress])
>  tuner.set_input_parser(YamlParser())
>  tuner.set_output_formatter(YamlOutput())
>  
>  # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.
> +# Compress is parameterized by others, so add it at the end.
>  tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,
> -                        filter, gamma_out, lsc])
> +                        filter, gamma_out, lsc, compress])
>  
>  if __name__ == '__main__':
>      sys.exit(tuner.run(sys.argv))
> -- 
> 2.48.1
>

Patch
diff mbox series 

diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py
index 207b717a029c..179d920c05df 100755
--- a/utils/tuning/rkisp1.py
+++ b/utils/tuning/rkisp1.py
@@ -27,6 +27,7 @@  awb = AWBRkISP1(debug=[lt.Debug.Plot])
 blc = StaticModule('BlackLevelCorrection')
 ccm = CCMRkISP1(debug=[lt.Debug.Plot])
 color_processing = StaticModule('ColorProcessing')
+compress = StaticModule('Compress')
 filter = StaticModule('Filter')
 gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2})
 lsc = LSCRkISP1(debug=[lt.Debug.Plot],
@@ -49,13 +50,14 @@  lsc = LSCRkISP1(debug=[lt.Debug.Plot],
 lux = LuxRkISP1(debug=[lt.Debug.Plot])
 
 tuner = lt.Tuner('RkISP1')
-tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux])
+tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, compress])
 tuner.set_input_parser(YamlParser())
 tuner.set_output_formatter(YamlOutput())
 
 # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.
+# Compress is parameterized by others, so add it at the end.
 tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,
-                        filter, gamma_out, lsc])
+                        filter, gamma_out, lsc, compress])
 
 if __name__ == '__main__':
     sys.exit(tuner.run(sys.argv))