| Message ID | 20250808141315.413839-3-stefan.klug@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
in $SUBJECT: s/rksip1/rkisp1/ Quoting Stefan Klug (2025-08-08 15:12:40) > Add a static Compress entry that gets added by default. > Can you state here that it uses the existing Compress module? I assume it's already existing - I don't know where from though - or has it not been used at all yet? > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> > --- > utils/tuning/rkisp1.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py > index 207b717a029c..179d920c05df 100755 > --- a/utils/tuning/rkisp1.py > +++ b/utils/tuning/rkisp1.py > @@ -27,6 +27,7 @@ awb = AWBRkISP1(debug=[lt.Debug.Plot]) > blc = StaticModule('BlackLevelCorrection') > ccm = CCMRkISP1(debug=[lt.Debug.Plot]) > color_processing = StaticModule('ColorProcessing') > +compress = StaticModule('Compress') > filter = StaticModule('Filter') > gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2}) > lsc = LSCRkISP1(debug=[lt.Debug.Plot], > @@ -49,13 +50,14 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot], > lux = LuxRkISP1(debug=[lt.Debug.Plot]) > > tuner = lt.Tuner('RkISP1') > -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux]) > +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, compress]) > tuner.set_input_parser(YamlParser()) > tuner.set_output_formatter(YamlOutput()) > > # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB. > +# Compress is parameterized by others, so add it at the end. > tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing, > - filter, gamma_out, lsc]) > + filter, gamma_out, lsc, compress]) > > if __name__ == '__main__': > sys.exit(tuner.run(sys.argv)) > -- > 2.48.1 >
Quoting Kieran Bingham (2025-08-08 17:11:49) > in $SUBJECT: s/rksip1/rkisp1/ > > Quoting Stefan Klug (2025-08-08 15:12:40) > > Add a static Compress entry that gets added by default. > > > > Can you state here that it uses the existing Compress module? > I assume it's already existing - I don't know where from though - or has > it not been used at all yet? Never mind - I assume StaticModule('Compress') is all it takes to add a basic entry to the tuning file to enable the component. > > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> > > --- > > utils/tuning/rkisp1.py | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py > > index 207b717a029c..179d920c05df 100755 > > --- a/utils/tuning/rkisp1.py > > +++ b/utils/tuning/rkisp1.py > > @@ -27,6 +27,7 @@ awb = AWBRkISP1(debug=[lt.Debug.Plot]) > > blc = StaticModule('BlackLevelCorrection') > > ccm = CCMRkISP1(debug=[lt.Debug.Plot]) > > color_processing = StaticModule('ColorProcessing') > > +compress = StaticModule('Compress') > > filter = StaticModule('Filter') > > gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2}) > > lsc = LSCRkISP1(debug=[lt.Debug.Plot], > > @@ -49,13 +50,14 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot], > > lux = LuxRkISP1(debug=[lt.Debug.Plot]) > > > > tuner = lt.Tuner('RkISP1') > > -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux]) > > +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, compress]) > > tuner.set_input_parser(YamlParser()) > > tuner.set_output_formatter(YamlOutput()) > > > > # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB. > > +# Compress is parameterized by others, so add it at the end. > > tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing, > > - filter, gamma_out, lsc]) > > + filter, gamma_out, lsc, compress]) > > > > if __name__ == '__main__': > > sys.exit(tuner.run(sys.argv)) > > -- > > 2.48.1 > >
On 08/08/2025 15:12, Stefan Klug wrote: > Add a static Compress entry that gets added by default. > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> > --- Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> > utils/tuning/rkisp1.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py > index 207b717a029c..179d920c05df 100755 > --- a/utils/tuning/rkisp1.py > +++ b/utils/tuning/rkisp1.py > @@ -27,6 +27,7 @@ awb = AWBRkISP1(debug=[lt.Debug.Plot]) > blc = StaticModule('BlackLevelCorrection') > ccm = CCMRkISP1(debug=[lt.Debug.Plot]) > color_processing = StaticModule('ColorProcessing') > +compress = StaticModule('Compress') > filter = StaticModule('Filter') > gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2}) > lsc = LSCRkISP1(debug=[lt.Debug.Plot], > @@ -49,13 +50,14 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot], > lux = LuxRkISP1(debug=[lt.Debug.Plot]) > > tuner = lt.Tuner('RkISP1') > -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux]) > +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, compress]) > tuner.set_input_parser(YamlParser()) > tuner.set_output_formatter(YamlOutput()) > > # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB. > +# Compress is parameterized by others, so add it at the end. > tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing, > - filter, gamma_out, lsc]) > + filter, gamma_out, lsc, compress]) > > if __name__ == '__main__': > sys.exit(tuner.run(sys.argv))
diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py index 207b717a029c..179d920c05df 100755 --- a/utils/tuning/rkisp1.py +++ b/utils/tuning/rkisp1.py @@ -27,6 +27,7 @@ awb = AWBRkISP1(debug=[lt.Debug.Plot]) blc = StaticModule('BlackLevelCorrection') ccm = CCMRkISP1(debug=[lt.Debug.Plot]) color_processing = StaticModule('ColorProcessing') +compress = StaticModule('Compress') filter = StaticModule('Filter') gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2}) lsc = LSCRkISP1(debug=[lt.Debug.Plot], @@ -49,13 +50,14 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot], lux = LuxRkISP1(debug=[lt.Debug.Plot]) tuner = lt.Tuner('RkISP1') -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux]) +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, compress]) tuner.set_input_parser(YamlParser()) tuner.set_output_formatter(YamlOutput()) # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB. +# Compress is parameterized by others, so add it at the end. tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing, - filter, gamma_out, lsc]) + filter, gamma_out, lsc, compress]) if __name__ == '__main__': sys.exit(tuner.run(sys.argv))
Add a static Compress entry that gets added by default. Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> --- utils/tuning/rkisp1.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)