[v2,4/4] libcamera: libipa: Add vd56g3 support for libipa
diff mbox series

Message ID 20250728-vd56g3_support-v2-4-cee5d5feac44@foss.st.com
State Accepted
Commit 409d1b29da7571735262691a5db85cf46e25bce7
Headers show
Series
  • Add vd56g3 support for rpi and libipa
Related show

Commit Message

Benjamin Mugnier July 28, 2025, 9:09 a.m. UTC 
Values are sourced initially from the vd56g3 user manual.

Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Kieran Bingham Aug. 6, 2025, 4:47 p.m. UTC | #1 
Quoting Benjamin Mugnier (2025-07-28 10:09:17)
> Values are sourced initially from the vd56g3 user manual.
> 
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Merging these.


> ---
>  src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> index 7c66cd57d6857e43863375d0b32d688fb5a1063c..dcd69d9f2bbb39feabfefe41cee8b45f0f958127 100644
> --- a/src/ipa/libipa/camera_sensor_helper.cpp
> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> @@ -745,6 +745,18 @@ public:
>  };
>  REGISTER_CAMERA_SENSOR_HELPER("ov13858", CameraSensorHelperOv13858)
>  
> +class CameraSensorHelperVd56g3 : public CameraSensorHelper
> +{
> +public:
> +       CameraSensorHelperVd56g3()
> +       {
> +               /* From datasheet: 0x40 at 10bits. */
> +               blackLevel_ = 4096;
> +               gain_ = AnalogueGainLinear{ 0, 32, -1, 32 };
> +       }
> +};
> +REGISTER_CAMERA_SENSOR_HELPER("vd56g3", CameraSensorHelperVd56g3)
> +
>  #endif /* __DOXYGEN__ */
>  
>  } /* namespace ipa */
> 
> -- 
> 2.25.1
>

Patch
diff mbox series 

diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
index 7c66cd57d6857e43863375d0b32d688fb5a1063c..dcd69d9f2bbb39feabfefe41cee8b45f0f958127 100644
--- a/src/ipa/libipa/camera_sensor_helper.cpp
+++ b/src/ipa/libipa/camera_sensor_helper.cpp
@@ -745,6 +745,18 @@  public:
 };
 REGISTER_CAMERA_SENSOR_HELPER("ov13858", CameraSensorHelperOv13858)
 
+class CameraSensorHelperVd56g3 : public CameraSensorHelper
+{
+public:
+	CameraSensorHelperVd56g3()
+	{
+		/* From datasheet: 0x40 at 10bits. */
+		blackLevel_ = 4096;
+		gain_ = AnalogueGainLinear{ 0, 32, -1, 32 };
+	}
+};
+REGISTER_CAMERA_SENSOR_HELPER("vd56g3", CameraSensorHelperVd56g3)
+
 #endif /* __DOXYGEN__ */
 
 } /* namespace ipa */