[libcamera-ci,1/3] Avoid duplicated documentation builds
diff mbox series

Message ID 20250727011123.31634-2-laurent.pinchart@ideasonboard.com
State Superseded
Headers show
Series
  • Prepare CI for Sphinx doxylink usage
Related show

Commit Message

Laurent Pinchart July 27, 2025, 1:11 a.m. UTC
The libcamera documentation is built as part of every build job. This
wastes CPU cycles. Build it only in the gcc 12 debug job, chosen
semi-randomly.

We could also split the documentation build to a separate job, but
short-running jobs are discouraged as they waste significant amount of
resources to spawn the container in the runner.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 gitlab-ci.yml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Barnabás Pőcze July 28, 2025, 2:18 p.m. UTC | #1
2025. 07. 27. 3:11 keltezéssel, Laurent Pinchart írta:
> The libcamera documentation is built as part of every build job. This
> wastes CPU cycles. Build it only in the gcc 12 debug job, chosen
> semi-randomly.
> 
> We could also split the documentation build to a separate job, but
> short-running jobs are discouraged as they waste significant amount of
> resources to spawn the container in the runner.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Looks ok to me.

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


> ---
>   gitlab-ci.yml | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/gitlab-ci.yml b/gitlab-ci.yml
> index cad4c2b0c445..03ea7795f3ff 100644
> --- a/gitlab-ci.yml
> +++ b/gitlab-ci.yml
> @@ -16,7 +16,7 @@ variables:
>       -D b_sanitize=address
>       -D cam=enabled
>       -D cpp_debugstl=true
> -    -D documentation=enabled
> +    -D documentation=disabled
>       -D gstreamer=enabled
>       -D lc-compliance=enabled
>       -D pipelines=['all']
> @@ -170,13 +170,16 @@ build-full:debian:12:
>     variables:
>       MESON_OPTIONS: >-
>         ${MESON_ALL_OPTIONS}
> -      -D doc_werror=true
>     parallel:
>       matrix:
>         - ARCH: amd64
>           BUILD_TYPE: debug
>           CC: gcc-12
>           CXX: g++-12
> +        MESON_OPTIONS: >-
> +          ${MESON_ALL_OPTIONS}
> +          -D documentation=enabled
> +          -D doc_werror=true
>         - ARCH: amd64
>           BUILD_TYPE: release
>           CC: gcc-12

Patch
diff mbox series

diff --git a/gitlab-ci.yml b/gitlab-ci.yml
index cad4c2b0c445..03ea7795f3ff 100644
--- a/gitlab-ci.yml
+++ b/gitlab-ci.yml
@@ -16,7 +16,7 @@  variables:
     -D b_sanitize=address
     -D cam=enabled
     -D cpp_debugstl=true
-    -D documentation=enabled
+    -D documentation=disabled
     -D gstreamer=enabled
     -D lc-compliance=enabled
     -D pipelines=['all']
@@ -170,13 +170,16 @@  build-full:debian:12:
   variables:
     MESON_OPTIONS: >-
       ${MESON_ALL_OPTIONS}
-      -D doc_werror=true
   parallel:
     matrix:
       - ARCH: amd64
         BUILD_TYPE: debug
         CC: gcc-12
         CXX: g++-12
+        MESON_OPTIONS: >-
+          ${MESON_ALL_OPTIONS}
+          -D documentation=enabled
+          -D doc_werror=true
       - ARCH: amd64
         BUILD_TYPE: release
         CC: gcc-12