| Message ID | 20250724105626.12718-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent On 24/07/2025 11:56, Laurent Pinchart wrote: > libcamera uses #pragma once for include guards. One manual guard crept > in lc-compliance, replace it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> > src/apps/lc-compliance/test_base.h | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/src/apps/lc-compliance/test_base.h b/src/apps/lc-compliance/test_base.h > index 0f32e3c21d0e..3451ef5f3724 100644 > --- a/src/apps/lc-compliance/test_base.h > +++ b/src/apps/lc-compliance/test_base.h > @@ -4,9 +4,7 @@ > * > * Base definitions for tests > */ > - > -#ifndef __LC_COMPLIANCE_TEST_BASE_H__ > -#define __LC_COMPLIANCE_TEST_BASE_H__ > +#pragma once > > #include <libcamera/libcamera.h> > > @@ -20,5 +18,3 @@ protected: > > std::shared_ptr<libcamera::Camera> camera_; > }; > - > -#endif /* __LC_COMPLIANCE_TEST_BASE_H__ */ > > base-commit: b65df7e7554b45e2d3d7fdb5b37c2ab7df3db4fe > prerequisite-patch-id: 8fcc899f628816b84d9ac265da673521706f45e2 > -- > Regards, > > Laurent Pinchart >
Hi Laurent On Thu, Jul 24, 2025 at 01:56:26PM +0300, Laurent Pinchart wrote: > libcamera uses #pragma once for include guards. One manual guard crept > in lc-compliance, replace it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks j > --- > src/apps/lc-compliance/test_base.h | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/src/apps/lc-compliance/test_base.h b/src/apps/lc-compliance/test_base.h > index 0f32e3c21d0e..3451ef5f3724 100644 > --- a/src/apps/lc-compliance/test_base.h > +++ b/src/apps/lc-compliance/test_base.h > @@ -4,9 +4,7 @@ > * > * Base definitions for tests > */ > - > -#ifndef __LC_COMPLIANCE_TEST_BASE_H__ > -#define __LC_COMPLIANCE_TEST_BASE_H__ > +#pragma once > > #include <libcamera/libcamera.h> > > @@ -20,5 +18,3 @@ protected: > > std::shared_ptr<libcamera::Camera> camera_; > }; > - > -#endif /* __LC_COMPLIANCE_TEST_BASE_H__ */ > > base-commit: b65df7e7554b45e2d3d7fdb5b37c2ab7df3db4fe > prerequisite-patch-id: 8fcc899f628816b84d9ac265da673521706f45e2 > -- > Regards, > > Laurent Pinchart >
diff --git a/src/apps/lc-compliance/test_base.h b/src/apps/lc-compliance/test_base.h index 0f32e3c21d0e..3451ef5f3724 100644 --- a/src/apps/lc-compliance/test_base.h +++ b/src/apps/lc-compliance/test_base.h @@ -4,9 +4,7 @@ * * Base definitions for tests */ - -#ifndef __LC_COMPLIANCE_TEST_BASE_H__ -#define __LC_COMPLIANCE_TEST_BASE_H__ +#pragma once #include <libcamera/libcamera.h> @@ -20,5 +18,3 @@ protected: std::shared_ptr<libcamera::Camera> camera_; }; - -#endif /* __LC_COMPLIANCE_TEST_BASE_H__ */
libcamera uses #pragma once for include guards. One manual guard crept in lc-compliance, replace it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/apps/lc-compliance/test_base.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) base-commit: b65df7e7554b45e2d3d7fdb5b37c2ab7df3db4fe prerequisite-patch-id: 8fcc899f628816b84d9ac265da673521706f45e2 -- Regards, Laurent Pinchart