[v5,1/2] package metadata
diff mbox series

Message ID 20250720112822.48250-2-Rauch.Christian@gmx.de
State New
Headers show
Series
  • package metadata
Related show

Commit Message

Christian Rauch July 20, 2025, 11:28 a.m. UTC
This metadata file provides meta information about the version, licence,
maintainers and build dependencies. The file is used by build systems, such
as colcon, to manage and resolve build dependencies.

The file structure is defined at: https://www.ros.org/reps/rep-0149.html

Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
---
 package.xml | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 package.xml

Comments

Kieran Bingham July 20, 2025, 3:25 p.m. UTC | #1
Quoting Christian Rauch (2025-07-20 12:28:21)
> This metadata file provides meta information about the version, licence,
> maintainers and build dependencies. The file is used by build systems, such
> as colcon, to manage and resolve build dependencies.
> 
> The file structure is defined at: https://www.ros.org/reps/rep-0149.html
> 
> Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>

I've previously given a tag, please keep tags when you've got them
unless there's significant changes made.

Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  package.xml | 45 +++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 package.xml
> 
> diff --git a/package.xml b/package.xml
> new file mode 100644
> index 000000000..814084c17
> --- /dev/null
> +++ b/package.xml
> @@ -0,0 +1,45 @@
> +<?xml version="1.0"?>
> +<!-- SPDX-License-Identifier: CC0-1.0 -->
> +<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
> +<package format="3">
> +  <name>libcamera</name>
> +
> +  <version>0.5.1</version>
> +
> +  <description>An open source camera stack and framework for Linux, Android, and ChromeOS</description>
> +
> +  <maintainer email="Rauch.Christian@gmx.de">Christian Rauch</maintainer>
> +  <maintainer email="Laurent.Pinchart@ideasonboard.com">Laurent Pinchart</maintainer>

What burden does this put on Laurent specifically? Does this mean he's
responsible from the ROS project perspective?



> +
> +  <license>Apache-2.0</license>
> +  <license>BSD-2-Clause</license>
> +  <license>BSD-3-Clause</license>
> +  <license>GPL-2.0-or-later</license>
> +  <license>LGPL-2.1-or-later</license>
> +
> +  <url>https://libcamera.org</url>
> +
> +  <author email="libcamera-devel@lists.libcamera.org">libcamera project</author>
> +
> +  <buildtool_depend>meson</buildtool_depend>
> +  <buildtool_depend>pkg-config</buildtool_depend>
> +  <buildtool_depend>git</buildtool_depend>
> +
> +  <build_depend>python3-yaml</build_depend>
> +  <build_depend>python3-ply</build_depend>
> +  <build_depend>python3-jinja2</build_depend>
> +  <build_depend>openssl</build_depend>
> +  <build_depend>pybind11-dev</build_depend>
> +
> +  <depend>yaml</depend>
> +  <depend>libssl-dev</depend>
> +  <depend>libudev-dev</depend>
> +  <depend>python3</depend>
> +
> +  <!-- workaround for https://bugs.libcamera.org/show_bug.cgi?id=189 -->
> +  <depend>libatomic</depend>
> +
> +  <export>
> +    <build_type>meson</build_type>
> +  </export>
> +</package>
> -- 
> 2.43.0
>
Christian Rauch July 20, 2025, 4:15 p.m. UTC | #2
Am 20.07.25 um 17:25 schrieb Kieran Bingham:
> Quoting Christian Rauch (2025-07-20 12:28:21)
>> This metadata file provides meta information about the version, licence,
>> maintainers and build dependencies. The file is used by build systems, such
>> as colcon, to manage and resolve build dependencies.
>>
>> The file structure is defined at: https://www.ros.org/reps/rep-0149.html
>>
>> Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
> 
> I've previously given a tag, please keep tags when you've got them
> unless there's significant changes made.
> 
> Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Oh, sorry. I wasn't aware that I am supposed to append these "Acked-by" 
or "Reviewed-by" tags to the commit myself. I always thought they are 
being applied automatically when the commits are merged.

>> ---
>>   package.xml | 45 +++++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 45 insertions(+)
>>   create mode 100644 package.xml
>>
>> diff --git a/package.xml b/package.xml
>> new file mode 100644
>> index 000000000..814084c17
>> --- /dev/null
>> +++ b/package.xml
>> @@ -0,0 +1,45 @@
>> +<?xml version="1.0"?>
>> +<!-- SPDX-License-Identifier: CC0-1.0 -->
>> +<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
>> +<package format="3">
>> +  <name>libcamera</name>
>> +
>> +  <version>0.5.1</version>
>> +
>> +  <description>An open source camera stack and framework for Linux, Android, and ChromeOS</description>
>> +
>> +  <maintainer email="Rauch.Christian@gmx.de">Christian Rauch</maintainer>
>> +  <maintainer email="Laurent.Pinchart@ideasonboard.com">Laurent Pinchart</maintainer>
> 
> What burden does this put on Laurent specifically? Does this mean he's
> responsible from the ROS project perspective?

This email address is primarily used for contact in case there are 
issues with the package itself, e.g. build failures or missing 
dependencies. AFAIK, only the first maintainer in the list is contacted 
automatically, but other maintainers could be contacted manually. Under 
normal circumstances, Laurent shouldn't need to do anything.

Most often, packages only have a single maintainer, but I added Laurent 
as he is the one with the most commits by a large margin and I did not 
want to appear as claiming to be the only one working on this.

I am happy to remove Laurent again. I simply did not want to appear as 
"owning" this package.

@Laurent: Let me know if you want to appear in the manifest, or if I 
should stay the sole maintainer of the package.

> 
>> +
>> +  <license>Apache-2.0</license>
>> +  <license>BSD-2-Clause</license>
>> +  <license>BSD-3-Clause</license>
>> +  <license>GPL-2.0-or-later</license>
>> +  <license>LGPL-2.1-or-later</license>
>> +
>> +  <url>https://libcamera.org</url>
>> +
>> +  <author email="libcamera-devel@lists.libcamera.org">libcamera project</author>
>> +
>> +  <buildtool_depend>meson</buildtool_depend>
>> +  <buildtool_depend>pkg-config</buildtool_depend>
>> +  <buildtool_depend>git</buildtool_depend>
>> +
>> +  <build_depend>python3-yaml</build_depend>
>> +  <build_depend>python3-ply</build_depend>
>> +  <build_depend>python3-jinja2</build_depend>
>> +  <build_depend>openssl</build_depend>
>> +  <build_depend>pybind11-dev</build_depend>
>> +
>> +  <depend>yaml</depend>
>> +  <depend>libssl-dev</depend>
>> +  <depend>libudev-dev</depend>
>> +  <depend>python3</depend>
>> +
>> +  <!-- workaround for https://bugs.libcamera.org/show_bug.cgi?id=189 -->
>> +  <depend>libatomic</depend>
>> +
>> +  <export>
>> +    <build_type>meson</build_type>
>> +  </export>
>> +</package>
>> -- 
>> 2.43.0
>>

Patch
diff mbox series

diff --git a/package.xml b/package.xml
new file mode 100644
index 000000000..814084c17
--- /dev/null
+++ b/package.xml
@@ -0,0 +1,45 @@ 
+<?xml version="1.0"?>
+<!-- SPDX-License-Identifier: CC0-1.0 -->
+<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
+<package format="3">
+  <name>libcamera</name>
+
+  <version>0.5.1</version>
+
+  <description>An open source camera stack and framework for Linux, Android, and ChromeOS</description>
+
+  <maintainer email="Rauch.Christian@gmx.de">Christian Rauch</maintainer>
+  <maintainer email="Laurent.Pinchart@ideasonboard.com">Laurent Pinchart</maintainer>
+
+  <license>Apache-2.0</license>
+  <license>BSD-2-Clause</license>
+  <license>BSD-3-Clause</license>
+  <license>GPL-2.0-or-later</license>
+  <license>LGPL-2.1-or-later</license>
+
+  <url>https://libcamera.org</url>
+
+  <author email="libcamera-devel@lists.libcamera.org">libcamera project</author>
+
+  <buildtool_depend>meson</buildtool_depend>
+  <buildtool_depend>pkg-config</buildtool_depend>
+  <buildtool_depend>git</buildtool_depend>
+
+  <build_depend>python3-yaml</build_depend>
+  <build_depend>python3-ply</build_depend>
+  <build_depend>python3-jinja2</build_depend>
+  <build_depend>openssl</build_depend>
+  <build_depend>pybind11-dev</build_depend>
+
+  <depend>yaml</depend>
+  <depend>libssl-dev</depend>
+  <depend>libudev-dev</depend>
+  <depend>python3</depend>
+
+  <!-- workaround for https://bugs.libcamera.org/show_bug.cgi?id=189 -->
+  <depend>libatomic</depend>
+
+  <export>
+    <build_type>meson</build_type>
+  </export>
+</package>