| Message ID | 20250717220539.2434556-2-dan.scally@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 21e54eff95b5935cb183c0250a71e49b90d6a4c2 |
| Headers | show |
| Series |
|
| Related | show |
Quoting Daniel Scally (2025-07-17 23:05:39) > The mali-c55 pipeline handler currently looks for a media entity with > the function MEDIA_ENT_F_IO_V4L to recognise a memory input subdevice. > This is apparently intended for video device entities, and we should > be looking for MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER. Correct the > entity function that the pipeline handler looks for. > > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp > index 17ad2055..25540ba1 100644 > --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp > +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp > @@ -1709,7 +1709,7 @@ bool PipelineHandlerMaliC55::match(DeviceEnumerator *enumerator) > * > * MEDIA_ENT_F_CAM_SENSOR - The test pattern generator > * MEDIA_ENT_F_VID_IF_BRIDGE - A CSI-2 receiver > - * MEDIA_ENT_F_IO_V4L - An input device > + * MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER - An input device > * > * The last one will be unsupported for now. The TPG is relatively easy, > * we just register a Camera for it. If we have a CSI-2 receiver we need > @@ -1735,7 +1735,7 @@ bool PipelineHandlerMaliC55::match(DeviceEnumerator *enumerator) > return registered; > > break; > - case MEDIA_ENT_F_IO_V4L: > + case MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER: > LOG(MaliC55, Warning) << "Memory input not yet supported"; > break; > default: > -- > 2.30.2 >
Hi Dan, Thank you for the patch! On Thu, 2025-07-17 at 23:05 +0100, Daniel Scally wrote: > The mali-c55 pipeline handler currently looks for a media entity with > the function MEDIA_ENT_F_IO_V4L to recognise a memory input > subdevice. > This is apparently intended for video device entities, and we should > be looking for MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER. Correct the > entity function that the pipeline handler looks for. > > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> > --- > src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp > b/src/libcamera/pipeline/mali-c55/mali-c55.cpp > index 17ad2055..25540ba1 100644 > --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp > +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp > @@ -1709,7 +1709,7 @@ bool > PipelineHandlerMaliC55::match(DeviceEnumerator *enumerator) > * > * MEDIA_ENT_F_CAM_SENSOR - The test pattern generator > * MEDIA_ENT_F_VID_IF_BRIDGE - A CSI-2 receiver > - * MEDIA_ENT_F_IO_V4L - An input device > + * MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER - An input device LGTM! Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com> > * > * The last one will be unsupported for now. The TPG is > relatively easy, > * we just register a Camera for it. If we have a CSI-2 > receiver we need > @@ -1735,7 +1735,7 @@ bool > PipelineHandlerMaliC55::match(DeviceEnumerator *enumerator) > return registered; > > break; > - case MEDIA_ENT_F_IO_V4L: > + case MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER: > LOG(MaliC55, Warning) << "Memory input not > yet supported"; > break; > default: Best wishes, Isaac
diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 17ad2055..25540ba1 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -1709,7 +1709,7 @@ bool PipelineHandlerMaliC55::match(DeviceEnumerator *enumerator) * * MEDIA_ENT_F_CAM_SENSOR - The test pattern generator * MEDIA_ENT_F_VID_IF_BRIDGE - A CSI-2 receiver - * MEDIA_ENT_F_IO_V4L - An input device + * MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER - An input device * * The last one will be unsupported for now. The TPG is relatively easy, * we just register a Camera for it. If we have a CSI-2 receiver we need @@ -1735,7 +1735,7 @@ bool PipelineHandlerMaliC55::match(DeviceEnumerator *enumerator) return registered; break; - case MEDIA_ENT_F_IO_V4L: + case MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER: LOG(MaliC55, Warning) << "Memory input not yet supported"; break; default:
The mali-c55 pipeline handler currently looks for a media entity with the function MEDIA_ENT_F_IO_V4L to recognise a memory input subdevice. This is apparently intended for video device entities, and we should be looking for MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER. Correct the entity function that the pipeline handler looks for. Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)