[v3] libcamera: camera_manager: Log info message to report camera creation

23804 diff mbox series

Camera creation is one of the most important events generated by
libcamera, but we are completely silent about it. The lack of a log
message makes it more difficult to identify problems and provide
support. Fix it by adding an Info message that reports the camera id and
its pipeline handler when the camera is added.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
Changes since v2:

- Rebase on latest master branch
---
 src/libcamera/camera_manager.cpp | 4 ++++
 1 file changed, 4 insertions(+)


base-commit: afd9890b7b9a65d95ef3295f52e01e0ec9ce7b3f
--
Regards,

Laurent Pinchart

On Sun, Jul 13, 2025 at 03:16:45PM +0300, Laurent Pinchart wrote:
> Camera creation is one of the most important events generated by
> libcamera, but we are completely silent about it. The lack of a log
> message makes it more difficult to identify problems and provide
> support. Fix it by adding an Info message that reports the camera id and
> its pipeline handler when the camera is added.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Umang Jain <uajain@igalia.com>

> ---
> Changes since v2:
> 
> - Rebase on latest master branch
> ---
>  src/libcamera/camera_manager.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp
> index e62e7193cfdc..f81794bfd6fe 100644
> --- a/src/libcamera/camera_manager.cpp
> +++ b/src/libcamera/camera_manager.cpp
> @@ -217,6 +217,10 @@ void CameraManager::Private::addCamera(std::shared_ptr<Camera> camera)
>  		cameras_.push_back(camera);
>  	}
> 
> +	LOG(Camera, Info)
> +		<< "Adding camera '" << camera->id() << "' for pipeline handler "
> +		<< camera->_d()->pipe()->name();
> +
>  	/* Report the addition to the public signal */
>  	CameraManager *const o = LIBCAMERA_O_PTR();
>  	o->cameraAdded.emit(camera);
> 
> base-commit: afd9890b7b9a65d95ef3295f52e01e0ec9ce7b3f
> --
> Regards,
> 
> Laurent Pinchart
>

2025. 07. 13. 14:16 keltezéssel, Laurent Pinchart írta:
> Camera creation is one of the most important events generated by
> libcamera, but we are completely silent about it. The lack of a log
> message makes it more difficult to identify problems and provide
> support. Fix it by adding an Info message that reports the camera id and
> its pipeline handler when the camera is added.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


> ---
> Changes since v2:
> 
> - Rebase on latest master branch
> ---
>   src/libcamera/camera_manager.cpp | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp
> index e62e7193cfdc..f81794bfd6fe 100644
> --- a/src/libcamera/camera_manager.cpp
> +++ b/src/libcamera/camera_manager.cpp
> @@ -217,6 +217,10 @@ void CameraManager::Private::addCamera(std::shared_ptr<Camera> camera)
>   		cameras_.push_back(camera);
>   	}
> 
> +	LOG(Camera, Info)
> +		<< "Adding camera '" << camera->id() << "' for pipeline handler "
> +		<< camera->_d()->pipe()->name();
> +
>   	/* Report the addition to the public signal */
>   	CameraManager *const o = LIBCAMERA_O_PTR();
>   	o->cameraAdded.emit(camera);
> 
> base-commit: afd9890b7b9a65d95ef3295f52e01e0ec9ce7b3f
> --
> Regards,
> 
> Laurent Pinchart
>