[v3] libcamera: camera_manager: Log info message to report camera creation
diff mbox series

Message ID 20250713121645.11776-1-laurent.pinchart@ideasonboard.com
State New
Headers show
Series
  • [v3] libcamera: camera_manager: Log info message to report camera creation
Related show

Commit Message

Laurent Pinchart July 13, 2025, 12:16 p.m. UTC 
Camera creation is one of the most important events generated by
libcamera, but we are completely silent about it. The lack of a log
message makes it more difficult to identify problems and provide
support. Fix it by adding an Info message that reports the camera id and
its pipeline handler when the camera is added.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
Changes since v2:

- Rebase on latest master branch
---
 src/libcamera/camera_manager.cpp | 4 ++++
 1 file changed, 4 insertions(+)


base-commit: afd9890b7b9a65d95ef3295f52e01e0ec9ce7b3f
--
Regards,

Laurent Pinchart

Patch
diff mbox series 

diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp
index e62e7193cfdc..f81794bfd6fe 100644
--- a/src/libcamera/camera_manager.cpp
+++ b/src/libcamera/camera_manager.cpp
@@ -217,6 +217,10 @@  void CameraManager::Private::addCamera(std::shared_ptr<Camera> camera)
 		cameras_.push_back(camera);
 	}

+	LOG(Camera, Info)
+		<< "Adding camera '" << camera->id() << "' for pipeline handler "
+		<< camera->_d()->pipe()->name();
+
 	/* Report the addition to the public signal */
 	CameraManager *const o = LIBCAMERA_O_PTR();
 	o->cameraAdded.emit(camera);