| Message ID | 20250708085147.752248-2-naush@raspberrypi.com |
|---|---|
| State | Accepted |
| Commit | a4372127534dd9093a0ec4c3e12465ae800257e6 |
| Headers | show |
| Series |
|
| Related | show |
Hi Naush Thanks for the patch. On Tue, 8 Jul 2025 at 09:52, Naushir Patuck <naush@raspberrypi.com> wrote: > > Remove the hypenation in "micro-seconds" in the description for the s/hypenation/hyphenation/ (sorry!) > ExposureTime control to match the rest of the document. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > --- > src/libcamera/control_ids_core.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml > index 46f51436c215..566e1533702f 100644 > --- a/src/libcamera/control_ids_core.yaml > +++ b/src/libcamera/control_ids_core.yaml > @@ -212,7 +212,7 @@ controls: > description: | > Exposure time for the frame applied in the sensor device. > > - This value is specified in micro-seconds. > + This value is specified in microseconds. With the typo fixed: Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Thanks David > > This control will only take effect if ExposureTimeMode is Manual. If > this control is set when ExposureTimeMode is Auto, the value will be > -- > 2.43.0 >
Quoting David Plowman (2025-07-08 10:06:57) > Hi Naush > > Thanks for the patch. > > On Tue, 8 Jul 2025 at 09:52, Naushir Patuck <naush@raspberrypi.com> wrote: > > > > Remove the hypenation in "micro-seconds" in the description for the > > s/hypenation/hyphenation/ > > (sorry!) I think we need to hype this up :-) Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > ExposureTime control to match the rest of the document. > > > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > --- > > src/libcamera/control_ids_core.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml > > index 46f51436c215..566e1533702f 100644 > > --- a/src/libcamera/control_ids_core.yaml > > +++ b/src/libcamera/control_ids_core.yaml > > @@ -212,7 +212,7 @@ controls: > > description: | > > Exposure time for the frame applied in the sensor device. > > > > - This value is specified in micro-seconds. > > + This value is specified in microseconds. > > With the typo fixed: > > Reviewed-by: David Plowman <david.plowman@raspberrypi.com> > > Thanks > David > > > > > This control will only take effect if ExposureTimeMode is Manual. If > > this control is set when ExposureTimeMode is Auto, the value will be > > -- > > 2.43.0 > >
diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml index 46f51436c215..566e1533702f 100644 --- a/src/libcamera/control_ids_core.yaml +++ b/src/libcamera/control_ids_core.yaml @@ -212,7 +212,7 @@ controls: description: | Exposure time for the frame applied in the sensor device. - This value is specified in micro-seconds. + This value is specified in microseconds. This control will only take effect if ExposureTimeMode is Manual. If this control is set when ExposureTimeMode is Auto, the value will be
Remove the hypenation in "micro-seconds" in the description for the ExposureTime control to match the rest of the document. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/libcamera/control_ids_core.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)