| Message ID | 20250704180641.1882328-1-Rauch.Christian@gmx.de |
|---|---|
| State | Accepted |
| Commit | 17eed522e8ff835fd96158aed40818346636032b |
| Headers | show |
| Series |
|
| Related | show |
Hi Christian, Thanks for the patch. On Fri, 4 Jul 2025 at 19:07, Christian Rauch <Rauch.Christian@gmx.de> wrote: > > Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de> I think you might want to add a line or two in the commit message about the existing warning generated. Otherwise, happy to go ahead with this. Reviewed-by: Naushir Patuck <naush@raspberrypi.com> > --- > subprojects/libpisp.wrap | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/subprojects/libpisp.wrap b/subprojects/libpisp.wrap > index 8b62c036f..0e0c7baaf 100644 > --- a/subprojects/libpisp.wrap > +++ b/subprojects/libpisp.wrap > @@ -2,5 +2,5 @@ > > [wrap-git] > url = https://github.com/raspberrypi/libpisp.git > -revision = v1.2.0 > +revision = v1.2.1 > depth = 1 > -- > 2.43.0 >
Quoting Naushir Patuck (2025-07-07 09:23:56) > Hi Christian, > > Thanks for the patch. > > On Fri, 4 Jul 2025 at 19:07, Christian Rauch <Rauch.Christian@gmx.de> wrote: > > > > Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de> > > I think you might want to add a line or two in the commit message > about the existing warning generated. Otherwise, happy to go ahead > with this. Is there any helpful reference to an issue tracker too? I would recommend keeping the commit title simple and the rationale in the commit message as : """ subprojects: libpisp: Update to 1.2.1 Update the libpisp wrap to use the latest 1.2.1 release which silences an 'unused-parameter' warning. Bug: <link to relevant bug tracker or otherwise if relevant> Reviewed-by: Naushir Patuck <naush@raspberrypi.com> Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de> """ Can be updated while applying easily though. Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Reviewed-by: Naushir Patuck <naush@raspberrypi.com> > > > --- > > subprojects/libpisp.wrap | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/subprojects/libpisp.wrap b/subprojects/libpisp.wrap > > index 8b62c036f..0e0c7baaf 100644 > > --- a/subprojects/libpisp.wrap > > +++ b/subprojects/libpisp.wrap > > @@ -2,5 +2,5 @@ > > > > [wrap-git] > > url = https://github.com/raspberrypi/libpisp.git > > -revision = v1.2.0 > > +revision = v1.2.1 > > depth = 1 > > -- > > 2.43.0 > >
diff --git a/subprojects/libpisp.wrap b/subprojects/libpisp.wrap index 8b62c036f..0e0c7baaf 100644 --- a/subprojects/libpisp.wrap +++ b/subprojects/libpisp.wrap @@ -2,5 +2,5 @@ [wrap-git] url = https://github.com/raspberrypi/libpisp.git -revision = v1.2.0 +revision = v1.2.1 depth = 1
Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de> --- subprojects/libpisp.wrap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)